Re: [Xen-devel] [PATCH for-4.13 v3] xen/arm: domain_build: Don't expose IOMMU specific properties to hwdom

[Julien Grall <julien.grall@xxxxxxx>]

Hi Oleksandr,

On 10/16/19 11:08 AM, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> We always skip the IOMMU device when creating DT for hwdom if there is
> an appropriate driver for it in Xen (device_get_class(iommu_node)
> returns DEVICE_IOMMU). So, even if it is not used by Xen it will be skipped.
>
> We should also skip the IOMMU specific properties of the master device
> behind that IOMMU in order to avoid exposing an half complete IOMMU
> bindings to hwdom.
>
> According to the Linux's docs:
> 1. Documentation/devicetree/bindings/iommu/iommu.txt
> 2. Documentation/devicetree/bindings/pci/pci-iommu.txt
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxx>

@Juergen: while the driver relying on those bindings is experimental for 
Xen 4.13, it would be good to avoid exposing half the bindings of IOMMU.
The bindings are generic but it is not used by the SMMU driver yet and 
therefore should not affect platform using SMMUs.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel