Re: [Xen-devel] [PATCH v3 5/7] x86/livepatch: Fail the build if duplicate symbols exist

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On October 23, 2019 10:46:37 AM EDT, "Jürgen Groß" <jgross@xxxxxxxx> wrote:
>On 23.10.19 15:58, Andrew Cooper wrote:
>> From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>> 
>> The binary diffing algorithm used by xen-livepatch depends on having
>unique
>> symbols.
>> 
>> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
>> 
>> The livepatch loading algorithm used by Xen resolves relocations by
>symbol
>> name, and thus also depends on having unique symbols.
>> 
>> Introduce CONFIG_ENFORCE_UNIQUE_SYMBOLS to control failing the build
>if
>> duplicate symbols are found, and disable it in the RANDCONFIG build.
>> 
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

What is up with that SoBs not being together?

Could you squash them please?

Patch wise, feel free to add my Reviewed-by.

Thx
>
>Release-acked-by: Juergen Gross <jgross@xxxxxxxx>
>
>
>Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel