Re: [Xen-devel] [PATCH for-next v3 1/9] x86: introduce CONFIG_GUEST and move code

[Wei Liu <wl@xxxxxxx>]

On Wed, Oct 23, 2019 at 08:55:24AM +0100, Paul Durrant wrote:
> On Mon, 21 Oct 2019 at 16:59, Wei Liu <wl@xxxxxxx> wrote:
> >
> > Xen is able to run as a guest on Xen. We plan to make it able to run
> > on Hyper-V as well.
> >
> > Introduce CONFIG_GUEST which is set to true if either running on Xen
> > or Hyper-V is desired. Restructure code hierarchy for new code to
> > come.
> >
> > No functional change intended.
> >
> > Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
> > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> >  xen/arch/x86/Kconfig                          | 4 ++++
> >  xen/arch/x86/Makefile                         | 2 +-
> >  xen/arch/x86/guest/Makefile                   | 5 +----
> >  xen/arch/x86/guest/xen/Makefile               | 4 ++++
> >  xen/arch/x86/guest/{ => xen}/hypercall_page.S | 0
> >  xen/arch/x86/guest/{ => xen}/pvh-boot.c       | 0
> >  xen/arch/x86/guest/{ => xen}/xen.c            | 0
> >  7 files changed, 10 insertions(+), 5 deletions(-)
> >  create mode 100644 xen/arch/x86/guest/xen/Makefile
> >  rename xen/arch/x86/guest/{ => xen}/hypercall_page.S (100%)
> >  rename xen/arch/x86/guest/{ => xen}/pvh-boot.c (100%)
> >  rename xen/arch/x86/guest/{ => xen}/xen.c (100%)
> >
> > diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig
> > index 28b3b4692a..867de857e8 100644
> > --- a/xen/arch/x86/Kconfig
> > +++ b/xen/arch/x86/Kconfig
> > @@ -161,8 +161,12 @@ config XEN_ALIGN_2M
> >
> >  endchoice
> >
> > +config GUEST
> > +       bool
> > +
> >  config XEN_GUEST
> >         def_bool n
> > +       select GUEST
> >         prompt "Xen Guest"
> >         ---help---
> >           Support for Xen detecting when it is running under Xen.
> 
> This text needs to be modified. Perhaps just say 'when it is running
> in a virtual machine'. That should be future-proof.
> 

I don't think it should be modified -- XEN_GUEST here really means
specifically running under Xen but not others.

We will later introduced HYPERV_GUEST.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel