[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet



On 10/22/19 11:53 AM, Aleksandar Markovic wrote:


On Friday, October 18, 2019, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx <mailto:philmd@xxxxxxxxxx>> wrote:

    From: Hervé Poussineau <hpoussin@xxxxxxxxxxx
    <mailto:hpoussin@xxxxxxxxxxx>>

    Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4
    gpio out.
    Remove i8259 instanciated in malta board, to not have it twice.

    We can also remove the now unused piix4_init() function.

    Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx <mailto:mst@xxxxxxxxxx>>
    Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx
    <mailto:pbonzini@xxxxxxxxxx>>
    Signed-off-by: Hervé Poussineau <hpoussin@xxxxxxxxxxx
    <mailto:hpoussin@xxxxxxxxxxx>>
    Message-Id: <20171216090228.28505-8-hpoussin@xxxxxxxxxxx
    <mailto:20171216090228.28505-8-hpoussin@xxxxxxxxxxx>>
    Reviewed-by: Aleksandar Markovic <amarkovic@xxxxxxxxxxxx
    <mailto:amarkovic@xxxxxxxxxxxx>>
    [PMD: rebased, updated includes, use ISA_NUM_IRQS in for loop]
    Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx
    <mailto:philmd@xxxxxxxxxx>>
    ---
      hw/isa/piix4.c       | 43 ++++++++++++++++++++++++++++++++-----------
      hw/mips/mips_malta.c | 32 +++++++++++++-------------------
      include/hw/i386/pc.h |  1 -
      3 files changed, 45 insertions(+), 31 deletions(-)



A detail: In the title:
Add a i8259  -> Add an i8259

OK.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.