[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
- Date: Mon, 21 Oct 2019 19:12:23 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8fTLsgbvO3jKnQB8EQfU7dorG5dIAD4HEDgB6UX61y4=; b=mG+olQeI9D+PtGirNdNwOV0hNNe3Dv/TKENCrD4QjQ0QKLcW0UZuXdixOWCwUx+46KSfZKTpqa1tUpW4Lexg4a2l9Ly6YpBaGiZuEQXkTepxHh11s0xqkWQ4pfVX7llmGjjSlWsEMpCsSrOUSPDM5C44P+AFLxKR53OaiTByw8PGQtxJGrBlOp7i0vyzVFDfqpgGIy9+A2YNbJklhYnAhdpPDjRcTKOO/GTUrSJWLyUOi6p1hvqaIHyMB77BydHSOS/nOOk1FvxDJirk/huSvJBn0/kjxIaqOaq7mZzKycGjLwLjSPwyrDu2dvWXlCd+uwArB69etEUdBN8/B9le4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h06LGNT9sxkxR8EYajM/vurYHZTkaGDV4Jhdt7WbN/AmasgxQoGu1cGelLx3HgS/U6gN8xYh7rtoXhozSoZmJIGHnX8MhboP3GuA8Dw3NpgEXqeyVYGppFMZq+aLmln0nginfw4r3E8F5sBnzWTcgBllPwBAvKV28fQbKO5JNaqFi7eXFk6lwd9+Ufk5yrOgobODxH4W2gJXDFSCyJbakRTOxUn3WPa8mZMasMs/LpicwmiiK4Ebg9CM6nQLvCIA/mRRwSPpo7hBCTswn3zpuQ5VMy0sWzPlxQkxrWKBvw+dx06qnDCYTMkiLCgsxaV7ltYN1uKrPE8xjxPJLKmhUw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@xxxxxxxxxxxx;
- Cc: Jürgen Groß <jgross@xxxxxxxx>, Andrea Arcangeli <aarcange@xxxxxxxxxx>, Ralph Campbell <rcampbell@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, "Felix.Kuehling@xxxxxxx" <Felix.Kuehling@xxxxxxx>, "amd-gfx@xxxxxxxxxxxxxxxxxxxxx" <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, Jerome Glisse <jglisse@xxxxxxxxxx>, "dri-devel@xxxxxxxxxxxxxxxxxxxxx" <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Ben Skeggs <bskeggs@xxxxxxxxxx>
- Delivery-date: Tue, 22 Oct 2019 04:19:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVg4SlqgIWJTGEnUWY/9OWOhnZ6adcuS2AgAAXhoCACK8ugA==
- Thread-topic: [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER
On Wed, Oct 16, 2019 at 06:35:15AM +0000, Oleksandr Andrushchenko wrote:
> On 10/16/19 8:11 AM, Jürgen Groß wrote:
> > On 15.10.19 20:12, Jason Gunthorpe wrote:
> >> From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> >>
> >> DMA_SHARED_BUFFER can not be enabled by the user (it represents a
> >> library
> >> set in the kernel). The kconfig convention is to use select for such
> >> symbols so they are turned on implicitly when the user enables a kconfig
> >> that needs them.
> >>
> >> Otherwise the XEN_GNTDEV_DMABUF kconfig is overly difficult to enable.
> >>
> >> Fixes: 932d6562179e ("xen/gntdev: Add initial support for dma-buf UAPI")
> >> Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> >> Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> >> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> >> Cc: Juergen Gross <jgross@xxxxxxxx>
> >> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> >
> > Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
> >
> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
Thanks Oleksandr and Juergen, can you also give me some advice on how
to progress the more complex patch:
https://patchwork.kernel.org/patch/11191369/
Is this gntdev stuff still in-use? I struggled a bit to understand
what it is doing, but I think I made a reasonable guess?
Jason
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|