Re: [Xen-devel] [XEN PATCH for-4.13 v5 10/10] libxl/xl: Overhaul passthrough setting logic

[Julien Grall <julien.grall@xxxxxxx>]

Hi Ian,

On 18/10/2019 16:06, Ian Jackson wrote:
> diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c
> index bf31b9b3ca..2f1ca69431 100644
> --- a/tools/libxl/libxl_arm.c
> +++ b/tools/libxl/libxl_arm.c
> @@ -1191,6 +1191,30 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc 
> *gc,
>       libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH);
>   }
>   
> +int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc,
> +                                            uint32_t domid,
> +                                            libxl_domain_config *d_config,
> +                                            const libxl_physinfo *physinfo)
> +{
> +    int rc;
> +    libxl_domain_create_info *const c_info = &d_config->c_info;
> +
> +    if (c_info->passthrough == LIBXL_PASSTHROUGH_ENABLED) {
> +        c_info->passthrough = LIBXL_PASSTHROUGH_SHARE_PT;
> +    }
> +
> +    if (c_info->passthrough == LIBXL_PASSTHROUGH_SYNC_PT) {
> +        LOGD(ERROR, domid,
> +             "passthrough=\"sync_pt\" not supported on ARM\n");
> +        rc = ERROR_INVAL;
> +        goto out;
> +    }
Would it make sense to use a switch case or whitelist here? So we don't end up 
to slip through if a new type is added and unsupported on Arm.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel