Re: [Xen-devel] [RFC v5 000/126] error: auto propagated local_err

[Vladimir Sementsov-Ogievskiy <vsementsov@xxxxxxxxxxxxx>]

12.10.2019 5:52, no-reply@xxxxxxxxxxx wrote:
> Patchew URL: 
> https://patchew.org/QEMU/20191011160552.22907-1-vsementsov@xxxxxxxxxxxxx/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [RFC v5 000/126] error: auto propagated local_err
> Type: series
> Message-id: 20191011160552.22907-1-vsementsov@xxxxxxxxxxxxx
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Switched to a new branch 'test'
> 319b206 util/qemu-config.c: introduce ERRP_AUTO_PROPAGATE
> 3ee6567 tests/test-image-locking.c: introduce ERRP_AUTO_PROPAGATE
> 2e4f371 target/tilegx/cpu.c: introduce ERRP_AUTO_PROPAGATE
> 5f766d7 memory_mapping.c: introduce ERRP_AUTO_PROPAGATE
> 8969c6f iothread.c: introduce ERRP_AUTO_PROPAGATE
> 1534a92 hw/sd/ssi-sd.c: introduce ERRP_AUTO_PROPAGATE
> b5b1e0a hw/cpu/core.c: introduce ERRP_AUTO_PROPAGATE
> dd3f310 hw/core/bus.c: introduce ERRP_AUTO_PROPAGATE
> 21ee5f8 PVRDMA: introduce ERRP_AUTO_PROPAGATE
> 84365ab Replication: introduce ERRP_AUTO_PROPAGATE
> 225bbc5 vvfat: introduce ERRP_AUTO_PROPAGATE
> 2da58d6 vpc: introduce ERRP_AUTO_PROPAGATE
> e7fb0b9 blkdebug: introduce ERRP_AUTO_PROPAGATE
> 39d367e qcow: introduce ERRP_AUTO_PROPAGATE
> 1b7546c qcow2: introduce ERRP_AUTO_PROPAGATE
> c0352a1 raw: introduce ERRP_AUTO_PROPAGATE
> 612aebf qed: introduce ERRP_AUTO_PROPAGATE
> 155f6ea parallels: introduce ERRP_AUTO_PROPAGATE
> 5d3c3fd blkverify: introduce ERRP_AUTO_PROPAGATE
> 36132e6 blklogwrites: introduce ERRP_AUTO_PROPAGATE
> 785cfb4 Quorum: introduce ERRP_AUTO_PROPAGATE
> 5acba63 Bootdevice: introduce ERRP_AUTO_PROPAGATE
> 0e0d3fb NVMe Block Driver: introduce ERRP_AUTO_PROPAGATE
> 1cf6911 GLUSTER: introduce ERRP_AUTO_PROPAGATE
> cb4c8f7 CURL: introduce ERRP_AUTO_PROPAGATE
> 4e32493 SSH: introduce ERRP_AUTO_PROPAGATE
> abbecd4 NFS: introduce ERRP_AUTO_PROPAGATE
> f4f937d nbd: introduce ERRP_AUTO_PROPAGATE
> 7b638b3 iSCSI: introduce ERRP_AUTO_PROPAGATE
> 4727ffc VDI: introduce ERRP_AUTO_PROPAGATE
> 2c03145 VHDX: introduce ERRP_AUTO_PROPAGATE
> 7916a87 Sheepdog: introduce ERRP_AUTO_PROPAGATE
> db15fdd RBD: introduce ERRP_AUTO_PROPAGATE
> 05ea2cf VMDK: introduce ERRP_AUTO_PROPAGATE
> ff11144 Record/replay: introduce ERRP_AUTO_PROPAGATE
> a95fab2 colo: introduce ERRP_AUTO_PROPAGATE
> be71202 Sockets: introduce ERRP_AUTO_PROPAGATE
> 69a59b0 I/O Channels: introduce ERRP_AUTO_PROPAGATE
> e4f56f3 Cryptography: introduce ERRP_AUTO_PROPAGATE
> 4f5f412 Migration: introduce ERRP_AUTO_PROPAGATE
> 985da1a TPM: introduce ERRP_AUTO_PROPAGATE
> b19cdab Tracing: introduce ERRP_AUTO_PROPAGATE
> 3113fc7 SLIRP: introduce ERRP_AUTO_PROPAGATE
> 51e2f48 QMP: introduce ERRP_AUTO_PROPAGATE
> 1c0c827 QOM: introduce ERRP_AUTO_PROPAGATE
> fc0eec4 qga: introduce ERRP_AUTO_PROPAGATE
> af16041 QAPI: introduce ERRP_AUTO_PROPAGATE
> 21ed21e cryptodev: introduce ERRP_AUTO_PROPAGATE
> 7ab6e12 hostmem: introduce ERRP_AUTO_PROPAGATE
> 994c02c net: introduce ERRP_AUTO_PROPAGATE
> 26fe9a4 Human Monitor (HMP): introduce ERRP_AUTO_PROPAGATE
> 82b7f8b Main loop: introduce ERRP_AUTO_PROPAGATE
> 863100d Graphics: introduce ERRP_AUTO_PROPAGATE
> 45a8d41 SPICE: introduce ERRP_AUTO_PROPAGATE
> 6d967ec Memory API: introduce ERRP_AUTO_PROPAGATE
> 5645325 Dump: introduce ERRP_AUTO_PROPAGATE
> 6d795b4 cmdline: introduce ERRP_AUTO_PROPAGATE
> 5fceaa3 chardev: introduce ERRP_AUTO_PROPAGATE
> d551bda scsi: introduce ERRP_AUTO_PROPAGATE
> cc3d83e block: introduce ERRP_AUTO_PROPAGATE
> 75b948b Audio: introduce ERRP_AUTO_PROPAGATE
> c3fee2f XIVE: introduce ERRP_AUTO_PROPAGATE
> 42ba3e1 fw_cfg: introduce ERRP_AUTO_PROPAGATE
> 90c4efa virtio-gpu: introduce ERRP_AUTO_PROPAGATE
> 4db3f47 eepro100: introduce ERRP_AUTO_PROPAGATE
> d7634f4 NVDIMM: introduce ERRP_AUTO_PROPAGATE
> 706ee21 megasas: introduce ERRP_AUTO_PROPAGATE
> a037a5c virtio-rng: introduce ERRP_AUTO_PROPAGATE
> dcf1769 virtio-serial: introduce ERRP_AUTO_PROPAGATE
> 77d26d1 virtio-input: introduce ERRP_AUTO_PROPAGATE
> 7f62cb1 virtio-ccw: introduce ERRP_AUTO_PROPAGATE
> 2bdd860 virtio-blk: introduce ERRP_AUTO_PROPAGATE
> 026260e virtio-9p: introduce ERRP_AUTO_PROPAGATE
> 191c845 virtio: introduce ERRP_AUTO_PROPAGATE
> 24510de vhost: introduce ERRP_AUTO_PROPAGATE
> e8a1779 vfio-ccw: introduce ERRP_AUTO_PROPAGATE
> 00baaa3 VFIO: introduce ERRP_AUTO_PROPAGATE
> 361c201 USB (serial adapter): introduce ERRP_AUTO_PROPAGATE
> 0f70e97 USB: introduce ERRP_AUTO_PROPAGATE
> 9548378 SD (Secure Card): introduce ERRP_AUTO_PROPAGATE
> 90b472d SCSI: introduce ERRP_AUTO_PROPAGATE
> 312220a pflash: introduce ERRP_AUTO_PROPAGATE
> 47a7bb5 Network devices: introduce ERRP_AUTO_PROPAGATE
> bf2e1ef ACPI/SMBIOS: introduce ERRP_AUTO_PROPAGATE
> 98f6d04 PCI: introduce ERRP_AUTO_PROPAGATE
> e3e14fe IPack: introduce ERRP_AUTO_PROPAGATE
> 9ef097c Floppy: introduce ERRP_AUTO_PROPAGATE
> 4ffbc39 IDE: introduce ERRP_AUTO_PROPAGATE
> a91553f X86 Machines: introduce ERRP_AUTO_PROPAGATE
> a83188d S390 Machines: introduce ERRP_AUTO_PROPAGATE
> 8cbe8c9 SPARC Machines: introduce ERRP_AUTO_PROPAGATE
> a36009a PowerPC Machines: introduce ERRP_AUTO_PROPAGATE
> f82c520 MIPS Machines: introduce ERRP_AUTO_PROPAGATE
> 7033c7f ARM Machines: introduce ERRP_AUTO_PROPAGATE
> 13406bd Hosts: introduce ERRP_AUTO_PROPAGATE
> 6923a91 xen: introduce ERRP_AUTO_PROPAGATE
> 0170e9e kvm: introduce ERRP_AUTO_PROPAGATE
> 7c4b0d9 tcg: introduce ERRP_AUTO_PROPAGATE
> 5cb4ba6 s390x: introduce ERRP_AUTO_PROPAGATE
> 53edd88 misc: introduce ERRP_AUTO_PROPAGATE
> a296770 python: add commit-per-subsystem.py
> feedc38 scripts: add coccinelle script to use auto propagated errp
> e712d0e error: auto propagated local_err
> 64b786f hw/vfio/ap: drop local_err from vfio_ap_realize
> 54ef2b0 backends/cryptodev: drop local_err from cryptodev_backend_complete()
> c605b8b qapi/error: add (Error **errp) cleaning APIs
> be9f380 include/qom/object.h: rename Error ** parameter to more common errp
> 948a5a3 include/block/snapshot.h: rename Error ** parameter to more common 
> errp
> cda337b hw/usb: rename Error ** parameter to more common errp
> 1d22fd7 hw/tpm: rename Error ** parameter to more common errp
> 4023b59 hw/sd: rename Error ** parameter to more common errp
> c258678 hw/s390x: rename Error ** parameter to more common errp
> 07539ce monitor/qmp-cmds: rename Error ** parameter to more common errp
> a26c917 qga: rename Error ** parameter to more common errp
> 05cef6b hw/i386/amd_iommu: rename Error ** parameter to more common errp
> 398c2e9 block/snapshot: rename Error ** parameter to more common errp
> 4df0735 hw/core/qdev: cleanup Error ** variables
> a97739a 9pfs: well form error hint helpers
> f621e2a ppc: well form kvmppc_hint_smt_possible error hint helper
> cc9b38a nbd: well form nbd_iter_channel_error errp handler
> 9f18f68 qdev-monitor: well form error hint helpers
> 6c96ebe vnc: drop Error pointer indirection in vnc_client_io_error
> 8dac505 hmp: drop Error pointer indirection in hmp_handle_error
> ea1f06c error: rename errp to errp_in where it is IN-argument
> eb0e528 net/net: Clean up variable shadowing in net_client_init()
> 16c9d22 hw/core/loader-fit: fix freeing errp in fit_load_fdt
> 
> === OUTPUT BEGIN ===
> 1/126 Checking commit 16c9d22dbdf8 (hw/core/loader-fit: fix freeing errp in 
> fit_load_fdt)
> 2/126 Checking commit eb0e5289fbd9 (net/net: Clean up variable shadowing in 
> net_client_init())
> 3/126 Checking commit ea1f06c5177f (error: rename errp to errp_in where it is 
> IN-argument)
> 4/126 Checking commit 8dac50575fb7 (hmp: drop Error pointer indirection in 
> hmp_handle_error)
> 5/126 Checking commit 6c96ebe7980d (vnc: drop Error pointer indirection in 
> vnc_client_io_error)
> 6/126 Checking commit 9f18f68053d6 (qdev-monitor: well form error hint 
> helpers)
> 7/126 Checking commit cc9b38ae2be7 (nbd: well form nbd_iter_channel_error 
> errp handler)
> 8/126 Checking commit f621e2a212e4 (ppc: well form kvmppc_hint_smt_possible 
> error hint helper)
> 9/126 Checking commit a97739a33dbf (9pfs: well form error hint helpers)
> 10/126 Checking commit 4df0735d30e8 (hw/core/qdev: cleanup Error ** variables)
> 11/126 Checking commit 398c2e9b6b6d (block/snapshot: rename Error ** 
> parameter to more common errp)
> 12/126 Checking commit 05cef6ba60f4 (hw/i386/amd_iommu: rename Error ** 
> parameter to more common errp)
> 13/126 Checking commit a26c9171c17b (qga: rename Error ** parameter to more 
> common errp)
> 14/126 Checking commit 07539ce2d362 (monitor/qmp-cmds: rename Error ** 
> parameter to more common errp)
> 15/126 Checking commit c258678c3b76 (hw/s390x: rename Error ** parameter to 
> more common errp)
> 16/126 Checking commit 4023b59092f7 (hw/sd: rename Error ** parameter to more 
> common errp)
> 17/126 Checking commit 1d22fd7fc323 (hw/tpm: rename Error ** parameter to 
> more common errp)
> 18/126 Checking commit cda337b28d54 (hw/usb: rename Error ** parameter to 
> more common errp)
> 19/126 Checking commit 948a5a31d4b1 (include/block/snapshot.h: rename Error 
> ** parameter to more common errp)
> 20/126 Checking commit be9f38026447 (include/qom/object.h: rename Error ** 
> parameter to more common errp)
> 21/126 Checking commit c605b8ba94ea (qapi/error: add (Error **errp) cleaning 
> APIs)
> 22/126 Checking commit 54ef2b0ab6ea (backends/cryptodev: drop local_err from 
> cryptodev_backend_complete())
> 23/126 Checking commit 64b786fd77cb (hw/vfio/ap: drop local_err from 
> vfio_ap_realize)
> 24/126 Checking commit e712d0e3ad3b (error: auto propagated local_err)
> ERROR: Macros with multiple statements should be enclosed in a do - while loop

Sorry, but it worth it:)

> #79: FILE: include/qapi/error.h:381:
> +#define ERRP_AUTO_PROPAGATE()                                  \
> +    g_auto(ErrorPropagator) _auto_errp_prop = {.errp = errp};  \
> +    errp = ((errp == NULL || *errp == error_fatal)             \
> +            ? &_auto_errp_prop.local_err : errp)
> 
> total: 1 errors, 0 warnings, 44 lines checked
> 
> Patch 24/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 25/126 Checking commit feedc38f888e (scripts: add coccinelle script to use 
> auto propagated errp)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #11:
> new file mode 100644
> 
> total: 0 errors, 1 warnings, 118 lines checked
> 
> Patch 25/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 26/126 Checking commit a296770e4ed0 (python: add commit-per-subsystem.py)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #13:
> new file mode 100755
> 
> ERROR: line over 90 characters
> #51: FILE: python/commit-per-subsystem.py:34:
> +    ret = subprocess.check_output(['git', 'diff', '--name-only'], 
> encoding='utf-8').split('\n')
> 
> WARNING: line over 80 characters
> #102: FILE: python/commit-per-subsystem.py:85:
> +                        path, mapper[path][0], subsystem, mapper_name, 
> glob_count,
> 
> ERROR: line over 90 characters
> #142: FILE: python/commit-per-subsystem.py:125:
> +                                print('Warning: nothing corresponds to 
> "{}"'.format(fname))
> 
> ERROR: line over 90 characters
> #148: FILE: python/commit-per-subsystem.py:131:
> +                                    self.add(subsystem, f, 
> self.map_glob_file, 'glob-file', n)
> 
> ERROR: line over 90 characters
> #151: FILE: python/commit-per-subsystem.py:134:
> +                                    self.add(subsystem, f, 
> self.map_glob_dir, 'glob-dir', n)

I'll of course clean this all up.

> 
> total: 4 errors, 2 warnings, 204 lines checked
> 
> Patch 26/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 27/126 Checking commit 53edd882e0a2 (misc: introduce ERRP_AUTO_PROPAGATE)
> 28/126 Checking commit 5cb4ba6dc988 (s390x: introduce ERRP_AUTO_PROPAGATE)
> 29/126 Checking commit 7c4b0d9d6196 (tcg: introduce ERRP_AUTO_PROPAGATE)
> ERROR: suspect code indent for conditional statements (4, 4)
> #1360: FILE: target/i386/cpu.c:5405:
> +    if (*errp) {
>       }

Hmm. I'll try to drop such things with help of coccinelle.

> 
> total: 1 errors, 0 warnings, 1656 lines checked
> 
> Patch 29/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 30/126 Checking commit 0170e9e55113 (kvm: introduce ERRP_AUTO_PROPAGATE)
> 31/126 Checking commit 6923a91b51e4 (xen: introduce ERRP_AUTO_PROPAGATE)
> 32/126 Checking commit 13406bd38518 (Hosts: introduce ERRP_AUTO_PROPAGATE)
> 33/126 Checking commit 7033c7f6dbb2 (ARM Machines: introduce 
> ERRP_AUTO_PROPAGATE)
> 34/126 Checking commit f82c520e220f (MIPS Machines: introduce 
> ERRP_AUTO_PROPAGATE)
> 35/126 Checking commit a36009a9841f (PowerPC Machines: introduce 
> ERRP_AUTO_PROPAGATE)
> ERROR: suspect code indent for conditional statements (8, 8)
> #2325: FILE: hw/ppc/spapr_pci.c:1615:
> +        if (*errp) {
>           }
> 
> total: 1 errors, 0 warnings, 2188 lines checked
> 
> Patch 35/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 36/126 Checking commit 8cbe8c93d975 (SPARC Machines: introduce 
> ERRP_AUTO_PROPAGATE)
> 37/126 Checking commit a83188dacb99 (S390 Machines: introduce 
> ERRP_AUTO_PROPAGATE)
> 38/126 Checking commit a91553fe4d04 (X86 Machines: introduce 
> ERRP_AUTO_PROPAGATE)
> 39/126 Checking commit 4ffbc39501c4 (IDE: introduce ERRP_AUTO_PROPAGATE)
> 40/126 Checking commit 9ef097c08fd8 (Floppy: introduce ERRP_AUTO_PROPAGATE)
> 41/126 Checking commit e3e14fe9d883 (IPack: introduce ERRP_AUTO_PROPAGATE)
> 42/126 Checking commit 98f6d04bd17f (PCI: introduce ERRP_AUTO_PROPAGATE)
> 43/126 Checking commit bf2e1efbbb02 (ACPI/SMBIOS: introduce 
> ERRP_AUTO_PROPAGATE)
> 44/126 Checking commit 47a7bb584c29 (Network devices: introduce 
> ERRP_AUTO_PROPAGATE)
> 45/126 Checking commit 312220a1ddc8 (pflash: introduce ERRP_AUTO_PROPAGATE)
> 46/126 Checking commit 90b472de5a1d (SCSI: introduce ERRP_AUTO_PROPAGATE)
> 47/126 Checking commit 954837843356 (SD (Secure Card): introduce 
> ERRP_AUTO_PROPAGATE)
> 48/126 Checking commit 0f70e97614d7 (USB: introduce ERRP_AUTO_PROPAGATE)
> 49/126 Checking commit 361c2015322c (USB (serial adapter): introduce 
> ERRP_AUTO_PROPAGATE)
> 50/126 Checking commit 00baaa39204f (VFIO: introduce ERRP_AUTO_PROPAGATE)
> 51/126 Checking commit e8a177945afc (vfio-ccw: introduce ERRP_AUTO_PROPAGATE)
> 52/126 Checking commit 24510de2e8fc (vhost: introduce ERRP_AUTO_PROPAGATE)
> 53/126 Checking commit 191c845b48f3 (virtio: introduce ERRP_AUTO_PROPAGATE)
> 54/126 Checking commit 026260ea0442 (virtio-9p: introduce ERRP_AUTO_PROPAGATE)
> 55/126 Checking commit 2bdd8607add4 (virtio-blk: introduce 
> ERRP_AUTO_PROPAGATE)
> 56/126 Checking commit 7f62cb15ac25 (virtio-ccw: introduce 
> ERRP_AUTO_PROPAGATE)
> 57/126 Checking commit 77d26d1cfd2e (virtio-input: introduce 
> ERRP_AUTO_PROPAGATE)
> 58/126 Checking commit dcf176995f8c (virtio-serial: introduce 
> ERRP_AUTO_PROPAGATE)
> 59/126 Checking commit a037a5c408d5 (virtio-rng: introduce 
> ERRP_AUTO_PROPAGATE)
> 60/126 Checking commit 706ee2136358 (megasas: introduce ERRP_AUTO_PROPAGATE)
> 61/126 Checking commit d7634f485cf3 (NVDIMM: introduce ERRP_AUTO_PROPAGATE)
> 62/126 Checking commit 4db3f478d427 (eepro100: introduce ERRP_AUTO_PROPAGATE)
> 63/126 Checking commit 90c4efaa36e0 (virtio-gpu: introduce 
> ERRP_AUTO_PROPAGATE)
> 64/126 Checking commit 42ba3e1dd85c (fw_cfg: introduce ERRP_AUTO_PROPAGATE)
> 65/126 Checking commit c3fee2fc02f1 (XIVE: introduce ERRP_AUTO_PROPAGATE)
> 66/126 Checking commit 75b948b28b28 (Audio: introduce ERRP_AUTO_PROPAGATE)
> 67/126 Checking commit cc3d83e31b4e (block: introduce ERRP_AUTO_PROPAGATE)
> ERROR: suspect code indent for conditional statements (8, 8)
> #126: FILE: block.c:1298:
> +        if (*errp) {
>           } else if (bs->filename[0]) {
> 
> ERROR: suspect code indent for conditional statements (12, 12)
> #556: FILE: block.c:3784:
> +            if (*errp) {
>               } else {

Will try to update coccinelle for this.

> 
> ERROR: Error messages should not contain newlines
> #735: FILE: block.c:5791:
> +                             "This may become an error in future 
> versions.\n");

preexisting

> 
> total: 3 errors, 0 warnings, 2006 lines checked
> 
> Patch 67/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 68/126 Checking commit d551bdac29ec (scsi: introduce ERRP_AUTO_PROPAGATE)
> 69/126 Checking commit 5fceaa34a239 (chardev: introduce ERRP_AUTO_PROPAGATE)
> 70/126 Checking commit 6d795b43413c (cmdline: introduce ERRP_AUTO_PROPAGATE)
> 71/126 Checking commit 56453257b1ac (Dump: introduce ERRP_AUTO_PROPAGATE)
> 72/126 Checking commit 6d967ec1fdf9 (Memory API: introduce 
> ERRP_AUTO_PROPAGATE)
> 73/126 Checking commit 45a8d41d3e5f (SPICE: introduce ERRP_AUTO_PROPAGATE)
> 74/126 Checking commit 863100d31565 (Graphics: introduce ERRP_AUTO_PROPAGATE)
> 75/126 Checking commit 82b7f8bf101d (Main loop: introduce ERRP_AUTO_PROPAGATE)
> 76/126 Checking commit 26fe9a48828c (Human Monitor (HMP): introduce 
> ERRP_AUTO_PROPAGATE)
> 77/126 Checking commit 994c02c4e44c (net: introduce ERRP_AUTO_PROPAGATE)
> 78/126 Checking commit 7ab6e12b144c (hostmem: introduce ERRP_AUTO_PROPAGATE)
> 79/126 Checking commit 21ed21e21d02 (cryptodev: introduce ERRP_AUTO_PROPAGATE)
> 80/126 Checking commit af1604131cde (QAPI: introduce ERRP_AUTO_PROPAGATE)
> ERROR: suspect code indent for conditional statements (4, 4)
> #131: FILE: qapi/qapi-visit-core.c:156:
> +    if (*errp) {
>       } else if (value > max) {
> 
> ERROR: suspect code indent for conditional statements (4, 4)
> #147: FILE: qapi/qapi-visit-core.c:214:
> +    if (*errp) {
>       } else if (value < min || value > max) {
> 
> ERROR: suspect code indent for conditional statements (4, 4)
> #232: FILE: qapi/qmp-dispatch.c:133:
> +    if (*errp) {
>       } else if (cmd->options & QCO_NO_SUCCESS_RESP) {
> 
> total: 3 errors, 0 warnings, 182 lines checked
> 
> Patch 80/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 81/126 Checking commit fc0eec4158dc (qga: introduce ERRP_AUTO_PROPAGATE)
> ERROR: suspect code indent for conditional statements (4, 4)
> #378: FILE: qga/commands-posix.c:1587:
> +    if (*errp) {
>       } else {
> 
> ERROR: suspect code indent for conditional statements (4, 4)
> #407: FILE: qga/commands-posix.c:1613:
> +    if (*errp) {
>       } else {
> 
> ERROR: suspect code indent for conditional statements (4, 4)
> #438: FILE: qga/commands-posix.c:1643:
> +    if (*errp) {
>       } else {
> 
> total: 3 errors, 0 warnings, 669 lines checked
> 
> Patch 81/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 82/126 Checking commit 1c0c827d5ca3 (QOM: introduce ERRP_AUTO_PROPAGATE)
> ERROR: suspect code indent for conditional statements (8, 8)
> #277: FILE: hw/core/qdev-properties.c:671:
> +        if (*errp) {
>           } else if (value < -1 || value > 255) {
> 
> total: 1 errors, 0 warnings, 1298 lines checked
> 
> Patch 82/126 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 83/126 Checking commit 51e2f4872c1a (QMP: introduce ERRP_AUTO_PROPAGATE)
> 84/126 Checking commit 3113fc7bf720 (SLIRP: introduce ERRP_AUTO_PROPAGATE)
> 85/126 Checking commit b19cdab11e6c (Tracing: introduce ERRP_AUTO_PROPAGATE)
> 86/126 Checking commit 985da1a54aa6 (TPM: introduce ERRP_AUTO_PROPAGATE)
> 87/126 Checking commit 4f5f412b75c4 (Migration: introduce ERRP_AUTO_PROPAGATE)
> 88/126 Checking commit e4f56f3b8dae (Cryptography: introduce 
> ERRP_AUTO_PROPAGATE)
> 89/126 Checking commit 69a59b07492d (I/O Channels: introduce 
> ERRP_AUTO_PROPAGATE)
> 90/126 Checking commit be712020a7c1 (Sockets: introduce ERRP_AUTO_PROPAGATE)
> 91/126 Checking commit a95fab2ba9c0 (colo: introduce ERRP_AUTO_PROPAGATE)
> 92/126 Checking commit ff11144b4d5e (Record/replay: introduce 
> ERRP_AUTO_PROPAGATE)
> 93/126 Checking commit 05ea2cfe6a49 (VMDK: introduce ERRP_AUTO_PROPAGATE)
> 94/126 Checking commit db15fdd137ca (RBD: introduce ERRP_AUTO_PROPAGATE)
> 95/126 Checking commit 7916a87501ff (Sheepdog: introduce ERRP_AUTO_PROPAGATE)
> 96/126 Checking commit 2c03145f174d (VHDX: introduce ERRP_AUTO_PROPAGATE)
> 97/126 Checking commit 4727ffc9e2b1 (VDI: introduce ERRP_AUTO_PROPAGATE)
> 98/126 Checking commit 7b638b375230 (iSCSI: introduce ERRP_AUTO_PROPAGATE)
> 99/126 Checking commit f4f937dedc90 (nbd: introduce ERRP_AUTO_PROPAGATE)
> 100/126 Checking commit abbecd4c8ca1 (NFS: introduce ERRP_AUTO_PROPAGATE)
> 101/126 Checking commit 4e324932309d (SSH: introduce ERRP_AUTO_PROPAGATE)
> 102/126 Checking commit cb4c8f74b637 (CURL: introduce ERRP_AUTO_PROPAGATE)
> 103/126 Checking commit 1cf6911a3113 (GLUSTER: introduce ERRP_AUTO_PROPAGATE)
> 104/126 Checking commit 0e0d3fbc80a8 (NVMe Block Driver: introduce 
> ERRP_AUTO_PROPAGATE)
> 105/126 Checking commit 5acba634d3f2 (Bootdevice: introduce 
> ERRP_AUTO_PROPAGATE)
> 106/126 Checking commit 785cfb4bfd6e (Quorum: introduce ERRP_AUTO_PROPAGATE)
> 107/126 Checking commit 36132e6d953e (blklogwrites: introduce 
> ERRP_AUTO_PROPAGATE)
> 108/126 Checking commit 5d3c3fde30a1 (blkverify: introduce 
> ERRP_AUTO_PROPAGATE)
> 109/126 Checking commit 155f6ea5fe1b (parallels: introduce 
> ERRP_AUTO_PROPAGATE)
> 110/126 Checking commit 612aebf400b0 (qed: introduce ERRP_AUTO_PROPAGATE)
> 111/126 Checking commit c0352a192b8f (raw: introduce ERRP_AUTO_PROPAGATE)
> 112/126 Checking commit 1b7546c66586 (qcow2: introduce ERRP_AUTO_PROPAGATE)
> 113/126 Checking commit 39d367e15ae7 (qcow: introduce ERRP_AUTO_PROPAGATE)
> 114/126 Checking commit e7fb0b9d3ec5 (blkdebug: introduce ERRP_AUTO_PROPAGATE)
> 115/126 Checking commit 2da58d6731e0 (vpc: introduce ERRP_AUTO_PROPAGATE)
> 116/126 Checking commit 225bbc51c347 (vvfat: introduce ERRP_AUTO_PROPAGATE)
> 117/126 Checking commit 84365ab2dc2d (Replication: introduce 
> ERRP_AUTO_PROPAGATE)
> 118/126 Checking commit 21ee5f83d833 (PVRDMA: introduce ERRP_AUTO_PROPAGATE)
> 119/126 Checking commit dd3f3104f838 (hw/core/bus.c: introduce 
> ERRP_AUTO_PROPAGATE)
> 120/126 Checking commit b5b1e0a54e36 (hw/cpu/core.c: introduce 
> ERRP_AUTO_PROPAGATE)
> 121/126 Checking commit 1534a928d277 (hw/sd/ssi-sd.c: introduce 
> ERRP_AUTO_PROPAGATE)
> 122/126 Checking commit 8969c6fe5523 (iothread.c: introduce 
> ERRP_AUTO_PROPAGATE)
> 123/126 Checking commit 5f766d764fb0 (memory_mapping.c: introduce 
> ERRP_AUTO_PROPAGATE)
> 124/126 Checking commit 2e4f3717dda3 (target/tilegx/cpu.c: introduce 
> ERRP_AUTO_PROPAGATE)
> 125/126 Checking commit 3ee65677767a (tests/test-image-locking.c: introduce 
> ERRP_AUTO_PROPAGATE)
> 126/126 Checking commit 319b2061bfba (util/qemu-config.c: introduce 
> ERRP_AUTO_PROPAGATE)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20191011160552.22907-1-vsementsov@xxxxxxxxxxxxx/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@xxxxxxxxxx
> 


-- 
Best regards,
Vladimir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel