Re: [Xen-devel] [PATCH v2] xen/arm: platform: fix Raspberry Pi compatible string

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stewart,

Sorry for the delay in answer.

On 04/10/2019 01:47, Stewart Hildebrand wrote:
> Both upstream [1] and downstream [2] Linux kernels use "brcm,bcm2711"
> as the compatible string for Raspberry Pi 4. Add this string to our
> platform compatible list.
Did the RPI foundation released any kernel with the old binding?

If so, I am ok if we don't support the compatible in Xen (we don't have a 
release with it yet!), but it would be worth mentioning in the commit message 
that this is going to break for some users (TBD) so they need to upgrade.
@Juergen: I would like to consider this patch for Xen 4.13. This is limited to 
RPI4 and would avoid us to ship it with a compatible that is going to disappear.
> The brcm,bcm2838 convention is abandoned. Remove it.
>
> Rename the variables within the file to a rpi4_* prefix since the file
> is meant to cover the Raspberry Pi 4 platform.
>
> [1] https://patchwork.kernel.org/patch/11165407/
> [2] 
> https://github.com/raspberrypi/linux/commit/53fdd7b8c8cb9c87190caab4fd459f89e1b4a7f8
>
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>
> ---
>   xen/arch/arm/platforms/brcm-raspberry-pi.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/xen/arch/arm/platforms/brcm-raspberry-pi.c 
> b/xen/arch/arm/platforms/brcm-raspberry-pi.c
> index e22d2b3184..b697fa2c6c 100644
> --- a/xen/arch/arm/platforms/brcm-raspberry-pi.c
> +++ b/xen/arch/arm/platforms/brcm-raspberry-pi.c
> @@ -19,13 +19,13 @@
>   
>   #include <asm/platform.h>
>   
> -static const char *const brcm_bcm2838_dt_compat[] __initconst =
> +static const char *const rpi4_dt_compat[] __initconst =
>   {
> -    "brcm,bcm2838",
> +    "brcm,bcm2711",
>       NULL
>   };
>   
> -static const struct dt_device_match brcm_bcm2838_blacklist_dev[] __initconst =
> +static const struct dt_device_match rpi4_blacklist_dev[] __initconst =
>   {
>       /*
>        * The aux SPIs share an IRQ and a page with the aux UART.
> @@ -40,9 +40,9 @@ static const struct dt_device_match 
> brcm_bcm2838_blacklist_dev[] __initconst =
>       { /* sentinel */ },
>   };
>   
> -PLATFORM_START(brcm_bcm2838, "Raspberry Pi 4")
> -    .compatible     = brcm_bcm2838_dt_compat,
> -    .blacklist_dev  = brcm_bcm2838_blacklist_dev,
> +PLATFORM_START(rpi4, "Raspberry Pi 4")
> +    .compatible     = rpi4_dt_compat,
> +    .blacklist_dev  = rpi4_blacklist_dev,
>   PLATFORM_END
>   
>   /*
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel