[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()
- To: Juergen Gross <JGross@xxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Mon, 7 Oct 2019 08:49:58 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n069xuCnovRqDeClibPegWsTrNi5P1Yq6LDLXHoqjgE=; b=VtPbtTXfDzvBQZtmYpPxSaQT52wj4eIy/o7ug1JZZdjxKFgghj4cUmK23NgnGaRlpvlqpGqEutKQoxSjfIs9Eqi9m+FwZpG2wnQZoIksiY/CZ2MadUKgdXD5/hU8inQzdakVpt2hp8FG839qlkWU5oa4E8+Pp0ekkxZYdBxWYPlMBf1aozSPTC5Uvqy5wzjRcjF75BiZ3BPOt8N3twYZT+JD9HNy6d8yS2oNL9cEYs96n6Em/N3dKebV8uXq6IBjaUc/WXbkogiJRue14rSE6gulGNkipbtNeCZ9hY4VdpoS4NFXAhKGoGfy168WoIUCLWZ9y/NhEo+wCJEI931PrA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pvar4cK9XpmEKB4kkLZIzoTf1dCgdpIEYDXgqTDRcVSbpLhO2NL/WVVTf5zsFwyjn/ZETnXWZcJQNnA0qS8hLacpWmfCvkYBbWfOrE/THcdkEUGBTaog/6atwMJglAJxZcpNJHHkf/Rbvo/tTx553OOJ+sbOpLyI47eK+AHQeW4ZqCcIG5Q2Crlkz0eTsP/p+/YAqPufQtz+Y4pDqOnaLjRufJIkzu6jTXbiIxOErbwzJ1SLBWRver9ANbA+1EghWYFeE0Jz3a3nygEgueET/7gWSztQc2XAKDwT8ALL7H5i04yeEEamkS/+/6hYmhZv6rYOm9Effn+Mj0yKe3Y60Q==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>
- Delivery-date: Mon, 07 Oct 2019 08:54:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVen6W0VHyDZcf7kSoSuWd1KEok6dKhbKZgAAEQ4CAAAK+fYAAAoyAgAADme2AAAHrgIAACeTIgAAAfQCAAAgKE4ADRRIAgAD3JQA=
- Thread-topic: [Xen-devel] [PATCH] xen/sched: fix locking in sched_tick_[suspend|resume]()
On Sun, 2019-10-06 at 20:05 +0200, Jürgen Groß wrote:
> On 04.10.19 18:09, George Dunlap wrote:
> >
> > I can think of a couple of options:
> >
> > 1. Have schedule.c call s->tick_* when switching to / from idle
> >
> > 2. Get rid of s->tick_*, and have sched_credit.c suspend / resume
> > ticks
> > when switching to / from idle in csched_schedule()
> >
> > 3. Have schedule.c suspend / resume ticks, and have an interface
> > that
> > allows schedulers to enable / disable them.
> >
> > 4. Rework sched_credit to be tickless.
>
> I'm going with 2., as it will have multiple advantages:
>
Good choice! For these reasons:
> - not very intrusive
> - keeps credit specifics in credit
>
And also because, if you'd go for 4, I'm sure that reviewing something
like that would would cause me nightmares! :-O
Thanks and Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
