Re: [Xen-devel] [PATCH 1/2] efi/boot: fix set_color function

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.10.2019 13:25, Igor Druzhinin wrote:
> On 04/10/2019 12:14, Jan Beulich wrote:
>> On 04.10.2019 12:54, Igor Druzhinin wrote:
>>> On 04/10/2019 11:34, Jan Beulich wrote:
>>>> On 03.10.2019 15:49, Igor Druzhinin wrote:
>>>>> - 0 is a possible and allowed value for a color mask accroding to
>>>>>   UEFI Spec 2.6 (11.9) especially for reserved mask
>>>>
>>>> Hmm, looking at 2.8 (where it's section 12.9, which in turn is why
>>>> section titles would be more helpful in such references) I can't
>>>> see the case being mentioned explicitly. I can accept that
>>>> ReservedMask might be zero, but then I'd prefer to handle that
>>>> case in the caller, rather than allowing zero also for the three
>>>> colors.
>>>
>>> "If a bit is set in RedMask, GreenMask, or BlueMask then those bits of
>>> the pixel represent the corresponding color." - "If a bit is set..."
>>> implies it might not be set.
>>
>> This talks about the function of individual bits. There's nothing said
>> about not bit at all being set for a particular color.
>>
> 
> I know certainly that it's not only me who reads this sentence the same
> way - firmware developers as well. But if you insist I will restrict
> this change to reserved mask only.

Please do, unless you can provide a plausible (non-broken) scenario
where one of the three color masks could be zero.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel