[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [OSSTEST PATCH] Osstest.pm: Fix main_revision_job_cond after 0964bab7a9ea


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Date: Thu, 3 Oct 2019 10:50:04 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 03 Oct 2019 09:50:12 +0000
  • Ironport-sdr: dtlaAVr9p2Kkl2PojTWNPFUY3zRdiZQLH+1J7ui7ddFjQuiXWGgieo9ni8SUuEkuwBOpIyBBHc PpJ/3nCTkzaTqJNTltj6or3NZx6iUkv7uSzds/vs4N5MtFBj0A/QkRth8Z6OJbuXUaNaGtWjYR bMaRgbyU6DUMKrF4jb74zvx7w5Z7ZvYwtkdBiEwQ/+ywgl6EdpErgFxa4kE2839hT4F1eoq9qD kUF9VW8jHHm146ymxwW5+F8mcRJ1K5aRXDAW0iiaUjbldc6czxRF6nQFpLVQOG4uW1p2J97muG kjM=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

In
  other_revision_job_suffix: Take and pass referring runvar name
we updated main_revision_job_cond to pass a dummy 'x' for the new
parameter.  But the parameter is a sql expression, not a value,
and so an extra pair of quotes are needed.

This error broke sg-check-tested and this fix fixes it.

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---
 Osstest.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest.pm b/Osstest.pm
index c14531e3..d6c1b709 100644
--- a/Osstest.pm
+++ b/Osstest.pm
@@ -388,7 +388,7 @@ END
 
 sub main_revision_job_cond ($) {
     my ($jobfield) = @_;
-    return "(${\ other_revision_job_suffix($jobfield,'x','x') } = '')";
+    return "(${\ other_revision_job_suffix($jobfield,\"'x'\",'x') } = '')";
 }
 
 sub get_harness_rev () {
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.