Re: [Xen-devel] [PATCH v7b 5/8] xen/arm: assign devices to boot domains

[Oleksandr <olekstysh@xxxxxxxxx>]

On 01.10.19 02:30, Stefano Stabellini wrote:

Hi Stefano

> +
> +    /* If xen_force, we ignore IOMMU failures. */
> +    res = iommu_add_dt_device(node);
> +    if ( res < 0 )
> +        return xen_force ? 0 : -EINVAL;
Any specific reason to return -EINVAL if not forcing (why don't return 
res)?

> +
> +    res = iommu_assign_dt_device(kinfo->d, node);
> +    return res;
could be optimized:

return iommu_assign_dt_device(kinfo->d, node);


--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel