Re: [Xen-devel] [PATCH] xen/efi: have a common runtime setup function

[Jan Beulich <jbeulich@xxxxxxxx>]

On 01.10.2019 10:25, Juergen Gross wrote:
> @@ -281,4 +270,26 @@ void xen_efi_reset_system(int reset_type, efi_status_t 
> status,
>               BUG();
>       }
>  }
> -EXPORT_SYMBOL_GPL(xen_efi_reset_system);
> +
> +/*
> + * Set XEN EFI runtime services function pointers. Other fields of struct 
> efi,
> + * e.g. efi.systab, will be set like normal EFI.
> + */
> +void __init xen_efi_runtime_setup(void)
> +{
> +     efi.get_time                    = xen_efi_get_time;
> +     efi.set_time                    = xen_efi_set_time;
> +     efi.get_wakeup_time             = xen_efi_get_wakeup_time;
> +     efi.set_wakeup_time             = xen_efi_set_wakeup_time;
> +     efi.get_variable                = xen_efi_get_variable;
> +     efi.get_next_variable           = xen_efi_get_next_variable;
> +     efi.set_variable                = xen_efi_set_variable;
> +     efi.set_variable_nonblocking    = xen_efi_set_variable;
> +     efi.query_variable_info         = xen_efi_query_variable_info;
> +     efi.query_variable_info_nonblocking = xen_efi_query_variable_info;
> +     efi.update_capsule              = xen_efi_update_capsule;
> +     efi.query_capsule_caps          = xen_efi_query_capsule_caps;
> +     efi.get_next_high_mono_count    = xen_efi_get_next_high_mono_count;
> +     efi.reset_system                = xen_efi_reset_system;
> +}
> +EXPORT_SYMBOL_GPL(xen_efi_runtime_setup);

I don't think exporting an __init function is a good idea, and I also
don't see why the function would need exporting had it had the __init
dropped. With the line dropped
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel