Re: [Xen-devel] [PATCH for Xen 4.13] iommu/arm: Remove arch_iommu_populate_page_table() completely

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
> Sent: 30 September 2019 11:35
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: julien.grall@xxxxxxx; sstabellini@xxxxxxxxxx; volodymyr_babchuk@xxxxxxxx; 
> jgross@xxxxxxxx; Paul
> Durrant <Paul.Durrant@xxxxxxxxxx>; Oleksandr Tyshchenko 
> <oleksandr_tyshchenko@xxxxxxxx>
> Subject: [PATCH for Xen 4.13] iommu/arm: Remove 
> arch_iommu_populate_page_table() completely
> 
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> 
> The Arm realization should have been removed in the following commit
> as redundant:
> f89f555 remove late (on-demand) construction of IOMMU page tables
> 
> So, remove unused function completely.

Good catch.

Reviewed-by: Paul Durrant <paul@xxxxxxx>

> 
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> ---
>  xen/drivers/passthrough/arm/iommu.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/arm/iommu.c 
> b/xen/drivers/passthrough/arm/iommu.c
> index 76e1152..db3b07a 100644
> --- a/xen/drivers/passthrough/arm/iommu.c
> +++ b/xen/drivers/passthrough/arm/iommu.c
> @@ -132,12 +132,6 @@ void arch_iommu_domain_destroy(struct domain *d)
>  {
>  }
> 
> -int arch_iommu_populate_page_table(struct domain *d)
> -{
> -    /* The IOMMU shares the p2m with the CPU */
> -    return -ENOSYS;
> -}
> -
>  void __hwdom_init arch_iommu_hwdom_init(struct domain *d)
>  {
>  }
> --
> 2.7.4


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel