[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] ns16550: make PCI device hiding uniform
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Julien Grall <julien.grall@xxxxxxx>
- Date: Sun, 29 Sep 2019 10:01:52 +0100
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, KonradWilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Sun, 29 Sep 2019 09:02:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 9/3/19 4:55 PM, Roger Pau Monné wrote:
On Tue, Sep 03, 2019 at 05:13:38PM +0200, Jan Beulich wrote:
On 03.09.2019 16:15, Roger Pau Monné wrote:
On Tue, Sep 03, 2019 at 03:58:08PM +0200, Jan Beulich wrote:
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -763,23 +763,16 @@ static void __init ns16550_init_postirq(
#ifdef CONFIG_HAS_PCI
if ( uart->bar || uart->ps_bdf_enable )
{
- if ( !uart->param )
- pci_hide_device(0, uart->ps_bdf[0], PCI_DEVFN(uart->ps_bdf[1],
- uart->ps_bdf[2]));
- else
- {
- if ( uart->param->mmio &&
- rangeset_add_range(mmio_ro_ranges,
- uart->io_base,
- uart->io_base + uart->io_size - 1) )
- printk(XENLOG_INFO "Error while adding MMIO range of device to
mmio_ro_ranges\n");
+ if ( uart->param && uart->param->mmio &&
+ rangeset_add_range(mmio_ro_ranges, uart->io_base,
+ uart->io_base + uart->io_size - 1) )
+ printk(XENLOG_INFO "Error while adding MMIO range of device to
mmio_ro_ranges\n");
- if ( pci_ro_device(0, uart->ps_bdf[0],
- PCI_DEVFN(uart->ps_bdf[1], uart->ps_bdf[2])) )
- printk(XENLOG_INFO "Could not mark config space of %02x:%02x.%u
read-only.\n",
- uart->ps_bdf[0], uart->ps_bdf[1],
- uart->ps_bdf[2]);
- }
+ if ( pci_ro_device(0, uart->ps_bdf[0],
Don't you need to gate the call to pci_ro_device with
uart->ps_bdf_enable?
No, we want this for both the parse_pci() and the pci_uart_config()
case, which is what the surrounding if() (visible in context above)
checks. (Note also that previously there was no such check either,
so if anything it would be an orthogonal change anyway.)
Ack, I find it wrong that pci_uart_config sets the ps_bdf but not
ps_bdf_enable. From the description of the ps_bdf_enable field it
seems like ps_bdf is only valid if ps_bdf_enable is true, but that
doesn't seem to match pci_uart_config.
The change looks fine to me based on what was done before, hence:
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Acked-by: Julien Grall <julien.grall@xxxxxxx>
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
