[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH RFC for-4.13 05/10] xen/arm: alternative: Remove unused parameter for alternative_if_not_cap
- To: Julien Grall <julien.grall@xxxxxxx>
- From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Date: Fri, 27 Sep 2019 11:50:45 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MtQ60bsOsIosOOffnP6lOR7+sfAtlMOac6AR6rbiaIY=; b=jrBPOosafz8tz++tVl1xuFBSmf7NoWAqTSjCGY1EtOf5Zt9M+2Q6EIjWvADNHworiVASiUEBPy2pJhBLEMC5jk+rcOvdIL5eWacClzs6uCZ5XcgyZvL2CvpHGT2mUqWsaGOWk7FVTlA+q7jHEq/IFeSzmPC7t5NfCbIplzryymog7vyqyRP74iIEd6xomH7D9Y8tZiwHokzP6MNafo1+/M6z/ip+s4Z/asbK4z8aZJyUf/YHhddEKsvOGXZxBWaA0nVxukPNuohD14KM5/uFtTZwfl4S+f91lJDo0rKu8XthxeyDk2Tg5vdeIH7QdMTpd+qJWaru9rjG3Ela04Dtgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nItuDXEbRuQXv8W5q6WxLNyk6Pvc1EDvRR6eG8QbzKs1mKsx+dQNlzddZy1b0QXZzwKchWlHfviTp4G7BFopMfIolWXp1v/DFhIq728kdJK+Vn0O+488w7DmUWE8eAxCXF8b8Suf0hET2zN0VAZLzbLhHdFRwBRwAmu1JyJpIVEnkoSNfTMhmL/vf7pOS47ZDt81ZO/+1lSRJsiXmVJfUEqhIf3PEeOFAeMe7y8JqeBU7X8pctjvZ8Z3jfcBLLyufm8LYQRFf3pObnpoVUi+ZUA7Qyu4r4ddZ5KcJ30Phe9Yd6Tnqq8UuF41R6ay9j7onj4nZlfgxVZG1BKkotameg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "andrii.anisov@xxxxxxxxx" <andrii.anisov@xxxxxxxxx>
- Delivery-date: Fri, 27 Sep 2019 11:50:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVdJmTi9yvxhZTwkmjCGEisiAocqc/amMA
- Thread-topic: [PATCH RFC for-4.13 05/10] xen/arm: alternative: Remove unused parameter for alternative_if_not_cap
Julien Grall writes:
> The macro alternative_if_not_cap is taking two parameters. The second
> parameter is never used and it is hard to see how this can be used
> correctly as it is only protecting the alternative section magic.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr.babchuk@xxxxxxxx>
> ---
> xen/include/asm-arm/alternative.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/xen/include/asm-arm/alternative.h
> b/xen/include/asm-arm/alternative.h
> index dedb6dd001..2830a6da2d 100644
> --- a/xen/include/asm-arm/alternative.h
> +++ b/xen/include/asm-arm/alternative.h
> @@ -116,13 +116,11 @@ int apply_alternatives(const struct alt_instr *start,
> const struct alt_instr *en
> * The code that follows this macro will be assembled and linked as
> * normal. There are no restrictions on this code.
> */
> -.macro alternative_if_not cap, enable = 1
> - .if \enable
> +.macro alternative_if_not cap
> .pushsection .altinstructions, "a"
> altinstruction_entry 661f, 663f, \cap, 662f-661f, 664f-663f
> .popsection
> 661:
> - .endif
> .endm
>
> /*
--
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
