Re: [Xen-devel] [PATCH v4 8/8] xen/arm32: head: Use a page mapping for the 1:1 mapping in create_page_tables()

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 9/26/19 5:24 AM, Stefano Stabellini wrote:
> > @@ -530,16 +470,53 @@ create_page_tables:
> >           blo   1b
> >   
> >           /*
> > -         * Defer fixmap and dtb mapping until after paging enabled, to
> > -         * avoid them clashing with the 1:1 mapping.
> > +         * If Xen is loaded at exactly XEN_VIRT_START then we don't
> > +         * need an additional 1:1 mapping, the virtual mapping will
> > +         * suffice.
> >            */
> > +        cmp   r9, #XEN_VIRT_START
> > +        moveq pc, lr
> >   
> > -        /* boot pagetable setup complete */
> > +1:
> As far as I can tell, this 1 label is unused. If so, we should remove
> it. With that gone:
Hmmm, yes it is.

> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Thank you!

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel