[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 43/47] xen/sched: support multiple cpus per scheduling resource
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jürgen Groß <jgross@xxxxxxxx>
- Date: Wed, 25 Sep 2019 15:39:08 +0200
- Cc: Tim Deegan <tim@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 25 Sep 2019 13:39:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.09.19 15:49, Jan Beulich wrote:
On 14.09.2019 10:52, Juergen Gross wrote:
--- a/xen/common/schedule.c
+++ b/xen/common/schedule.c
@@ -59,7 +59,7 @@ integer_param("sched_ratelimit_us", sched_ratelimit_us);
enum sched_gran __read_mostly opt_sched_granularity = SCHED_GRAN_cpu;
unsigned int __read_mostly sched_granularity = 1;
bool __read_mostly sched_disable_smt_switching;
-const cpumask_t *sched_res_mask = &cpumask_all;
+cpumask_var_t sched_res_mask;
For a non-automatic variable it might be even easier to have it
be cpumask_t?
I can change that.
@@ -2401,6 +2407,8 @@ static int cpu_schedule_up(unsigned int cpu)
/* We start with cpu granularity. */
sd->granularity = 1;
+ cpumask_set_cpu(cpu, sched_res_mask);
I'm missing the clearing counterpart.
Oh, indeed. Good catch! Not that it would result in wrong behavior,
though.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|