[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 07/47] xen/sched: move per cpu scheduler private data into struct sched_resource
- To: Juergen Gross <JGross@xxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Tue, 24 Sep 2019 17:07:04 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dxWahxxanrEX1KGaPFhxD5h/pOHyQCKS3xiH8l7nyyg=; b=IahA/B4NLmh3JvLxYa8/mYvpaZwMVyNJe0/YuizuPdElN/DNIbIFsOnFXnIKn4MkEv6jiToy/Chb5Ujc2rm0eYaB3egW5k49JYgeTnbt+Hhu9TvkgH9mCFnfVqg03FOa33m1nlvzFFcbqENHIdcqk5rdOZtfUww6cl6+68zQD9LERSmzg3J4CsE4zqe1JJlzCDFmXqm0jGIleoNePksE5udCLEnBNzpYF7nOcHZkaeBHfzizpkJkHlqSU7TZ0Wx3eTUswlP5BRQBw2FDzoyMNNI2/ZLW5pTqkpA5jNG5KxHhbw8Jmip+nS63O21oB/mO5IjsF3jVOwmDUUEg5J2MCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fBqBELkt+NnLDJ0oOPkRJMCFXMP8VSSoH8DiQNwbSkFXCS5V3kUZo63ie+ly6QdOkkfU8B0piam5HMlrUSJF5rW53kDRq2POJUB0VaKy5BWqQWh2v13oZhAR6PDP87ITsk2atcUXKVomodPCaAwpdzjJon6A4zsocCyq4N+UDtJNw/0souCw7pIGXTTcKQvTBguhehKXf66heIz7+Wg01lPh0s8tMg1QaMIhNDDZ8apKxO6rkGBMlU1B7WT9/J9v7dKGzItIe7QsEM74iFQncvkSMS5kzP8ehi0Jh94B98uKjshhH8UL90QOusts0HXKGHo9DO40majgbBRX4LxpKQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "robert.vanvossen@xxxxxxxxxxxxxxx" <robert.vanvossen@xxxxxxxxxxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, "josh.whitehead@xxxxxxxxxxxxxxx" <josh.whitehead@xxxxxxxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 24 Sep 2019 17:13:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVatnbGS2FGNyAyU6AEPubfzKF1qczJ+qAgAecYwCAAAeMgIAAMs8AgAAgmIA=
- Thread-topic: [Xen-devel] [PATCH v3 07/47] xen/sched: move per cpu scheduler private data into struct sched_resource
On Tue, 2019-09-24 at 17:10 +0200, Jürgen Groß wrote:
> On 24.09.19 14:08, Jan Beulich wrote:
> > On 24.09.2019 13:41, Jürgen Groß wrote:
> > > Regarding to rename "sd" to "sr": I agree this would be a
> > > sensible
> > > change. OTOH I'd like to be consistent, so I'd like to defer that
> > > to
> > > the planned scheduling cleanup series.
> >
> > Seeing another introduction of "sd" in as late as patch 37, I
> > really
> > wonder if this approach (and the resulting extra code churn) is
> > indeed better than naming at least new variable instances properly
> > right away.
>
> Okay with me. What do scheduler maintainers think?
>
I do prefer 'sr'. As to whether this happens right now, but only for
new variables, or all at once in a followup series, either approach is
fine for me.
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
