Re: [Xen-devel] [PATCH v3 24/47] xen: switch from for_each_vcpu() to for_each_sched_unit()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 24.09.2019 14:13, Jürgen Groß  wrote:
> On 20.09.19 17:05, Jan Beulich wrote:
>> On 14.09.2019 10:52, Juergen Gross wrote:
>>> @@ -896,18 +929,22 @@ void restore_vcpu_affinity(struct domain *d)
>>>                       cpupool_domain_cpumask(d));
>>>           if ( cpumask_empty(cpumask_scratch_cpu(cpu)) )
>>>           {
>>> -            if ( v->affinity_broken )
>>> +            if ( sched_check_affinity_broken(unit) )
>>>               {
>>> -                sched_set_affinity(v, unit->cpu_hard_affinity_saved, NULL);
>>> -                v->affinity_broken = 0;
>>> +                /* Affinity settings of one vcpu are for the complete 
>>> unit. */
>>> +                sched_set_affinity(unit->vcpu_list,
>>> +                                   unit->cpu_hard_affinity_saved, NULL);
>>
>> Yet despite the comment the function gets passed a struct vcpu *,
>> and this doesn't look to change by the end of the series. Is there
>> a reason for this?
> 
> Yes. sched_set_affinity() is used from outside of schedule.c (by
> dom0_build.c).

How about changing the call there then, rather than having confusing
code here?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel