Re: [Xen-devel] [PATCH] xen/arm32: setup: Give a xenheap page to the boot allocator

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 20/09/2019 09:48, Jan Beulich wrote:
> On 20.09.2019 00:49, Stefano Stabellini wrote:
> > On Tue, 17 Sep 2019, Julien Grall wrote:
> > > @@ -665,6 +666,11 @@ static void __init setup_mm(void)
> > >   
> > >       setup_xenheap_mappings((e >> PAGE_SHIFT) - xenheap_pages, xenheap_pages);
> > >   
> > > +    /* We need a single mapped page for populating bootmem_region_list. */
> > > +    boot_mfn_start = mfn_add(xenheap_mfn_end, -1);
> > > +    boot_mfn_end = xenheap_mfn_end;
> > > +    init_boot_pages(mfn_to_maddr(boot_mfn_start), mfn_to_maddr(boot_mfn_end));
> > > +
> > >       /* Add non-xenheap memory */
> > >       for ( i = 0; i < bootinfo.mem.nr_banks; i++ )
> > >       {
> > > @@ -710,7 +716,7 @@ static void __init setup_mm(void)
> > >   
> > >       /* Add xenheap memory that was not already added to the boot allocator. */
> > >       init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start),
> > > -                       mfn_to_maddr(xenheap_mfn_end));
> > > +                       mfn_to_maddr(boot_mfn_end));
> > I can see what you are trying to do with this patch and it looks like
> > the right fix at the moment. However, shouldn't this last change:
> >
> >    mfn_to_maddr(boot_mfn_start)
Doh, yes it should. I will update the patch and resend it.

> Oh, indeed - when doing the review yesterday I thought I had
> carefully compared with how things looked prior to the change
> needing fixing up now, yet I didn't spot this (otherwise
> obvious) difference to the original code.
>
> Jan
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel