Re: [Xen-devel] [PATCH 17/35] libxl: Add libxl__ev_qmp to libxl__ao_device

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("Re: [PATCH 17/35] libxl: Add libxl__ev_qmp to 
libxl__ao_device"):
> On Tue, Sep 17, 2019 at 06:07:31PM +0100, Ian Jackson wrote:
> > It might be nice to add a comment about the field(s) of
> > libxl__ao_device which callers of libxl__prepare_ao_device are
> > expected to clean up themselves.
> 
> Something like that?
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -2581,6 +2581,10 @@ typedef void libxl__device_callback(libxl__egc*, 
> libxl__ao_device*);
>   * Once _prepare has been called on a libxl__ao_device, it is safe to just
>   * discard this struct, there's no need to call any destroy function.
>   * _prepare can also be called multiple times with the same libxl__ao_device.
> + *
> + * But if any of the fields `backend_ds', `timeout', `xswait', `qmp' is
> + * used by a caller of _prepare, the caller will have to arrange to clean
> + * or dispose of them.

LGTM

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel