Re: [Xen-devel] [PATCH 01/35] libxl: Make libxl_domain_unpause async

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("Re: [PATCH 01/35] libxl: Make libxl_domain_unpause 
async"):
> I thought that HAVE_* wasn't needed when the API version is bumped. But
> now I guess that the HAVE_* macro are the only way for an application
> to build against old version of libxl since the version number isn't
> exposed.

The application can #define the version number of the API it wants.

The HAVE is for an application that *doesn't* do that and wants
instead to adapt continually to our API changes.

> The question is, how many macro should there be? As many macro as there
> are function changed? Or just one?

One will do.

> If only one, I don't know how to call it, maybe on of or related:
>     LIBXL_HAVE_QMP_FN_ASYNC
>     LIBXL_HAVE_FN_USING_QMP_ASYNC
> with the same comment listing all affected functions.

Either of those is fine.  I will leave it to your judgement.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel