Re: [Xen-devel] [PATCH] create-diff-object: more precisely identify .rodata sections

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 18/09/2019, 11:44, "Wieczorkiewicz, Pawel" <wipawel@xxxxxxxxx> wrote:

    > On 18. Sep 2019, at 12:41, Ian Jackson <ian.jackson@xxxxxxxxxx> wrote:
    > 
    > Julien Grall writes ("Re: [PATCH] create-diff-object: more precisely 
identify .rodata sections"):
    >> On 18/09/2019 10:52, Wieczorkiewicz, Pawel wrote:
    >>> $ scripts/./add_maintainers.pl -d ~/git/livepatch-build-tools
    >> 
    >> '-d' only tells you where the patches files are. The script will look up 
for the 
    >> MAINTAINERS file in the current directory.
    > 
    > Hmmm.  I wonder if we could detect this situation somehow.  This will
    > be a common user error I think.

I don't think it is possible to detect that situation as git format-patch does 
not tell you which tree a patch was generated from.
    
    I should have looked twice before sending the patch out. But, what would be 
very helpful for me
    is additional option to the add_maintainers.pl script like: -m ./MAINTAINERS
    
In my view this is only really an issue if you create a patch or series and 
then do something else before finalizing and sending the patch, otherwise I 
would have tripped over this myself. But of course, if you work on multiple 
series at the same time that is an easy mistake to make.

I would expect that the most common directory structure for people is to have a 
directory structure such as
~/code/xen.git
~/code/livepatch-build-tools
...
~/code/patches 

and that people switch between git directories. Looking at the code, I should 
be able to add a -m option, which would work out the directory in which 
MAINTAINERS is, then switch to it, do the processing and switch back to where 
we started from.

However, this would only really work, if there was a strong recommendation in 
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Using_add_maintainers.pl_.28or_get_maintainer.pl.29_from_outside_of_xen.git
 telling people to use -m $path/MAKEFILE when working on multiple directories

Would that work?

Lars
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel