Re: [Xen-devel] [PATCH v10] x86/emulate: Send vm_event from emulate

[Jan Beulich <jbeulich@xxxxxxxx>]

On 17.09.2019 17:39, Alexandru Stefan ISAILA wrote:
> On 17.09.2019 18:04, Jan Beulich wrote:
>> On 17.09.2019 17:00, Alexandru Stefan ISAILA wrote:
>>> There is no problem, I understand the risk of having suspicious return
>>> values. I am not hanged on having this return. I used this to skip
>>> adding a new return value. I can do this if we agree on a suitable name
>>> for a new return value in enum hvm_translation_result. I can propose
>>> HVMTRANS_bad_gfn_access.
>>
>> How intrusive would such a change be?
>>
> 
> Only the return for hvm_copy_to_guest_linear() and 
> hvm_copy_from_guest_linear() will be affected.
> There are 2 places to add checks, in linear_write() and linear_read().
> The new return value can turn up only in hvm_emulate_one_vm_event() 
> context, when vm_event->send_event flag is true.

But why would e.g. the switch() in hvmemul_map_linear_addr() not
also need adjustment? And if the new return value is to be
mostly similar to HVMTRANS_gfn_paged_out, things like
hvmemul_rep_movs() ought to need adjustment too (possibly just
in the form of an added ASSERT(), but anyway).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel