Re: [Xen-devel] [PATCH 25/35] libxl_pci: Coding style of do_pci_add

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Anthony PERARD writes ("[PATCH 25/35] libxl_pci: Coding style of do_pci_add"):
> do_pci_add is going to be asynchronous, so we start by having a single
> path out of the function. All `return`s instead set rc and goto out.
> 
> While here, some use of `rc' was used to store the return value of
> libxc calls, change them to store into `r'. Also, add the value of `r'
> in the error message of those calls.
> 
> There were an `out' label that was use it seems to skip setting up the
> IRQ, the label has been renamed to `out_no_irq'.

I think you want to write "No functional change" ?
If so, then with that added to the commit message:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks,
ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel