Re: [Xen-devel] [PATCH v11 3/6] sysctl / libxl: report whether IOMMU/HAP page table sharing is supported

[Wei Liu <wl@xxxxxxx>]

On Fri, 13 Sep 2019 at 11:58, Paul Durrant <paul.durrant@xxxxxxxxxx> wrote:
>
> This patch defines a new bit reported in the hw_cap field of struct
> xen_sysctl_physinfo to indicate whether the platform supports sharing of
> HAP page tables (i.e. the P2M) with the IOMMU. This informs the toolstack
> whether the domain needs extra memory to store discrete IOMMU page tables
> or not.
>
> NOTE: This patch makes sure iommu_hap_pt_shared is clear if HAP is not
>       supported or the IOMMU is disabled, and defines it to false if
>       !CONFIG_HVM.
>
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Wei Liu <wl@xxxxxxx>
> Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>
> Cc: David Scott <dave@xxxxxxxxxx>
> Cc: "Roger Pau Monné" <roger.pau@xxxxxxxxxx>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Cc: Kevin Tian <kevin.tian@xxxxxxxxx>
>
> v11:
>  - Fix abi-check breakage
>
> v10:
>  - Set flag in common code (which means clearing iommu_hap_pt_share if
>    HAP cannot be enabled or is configured out).
>
> v9:
>  - New in v9
> ---
>  tools/libxl/libxl.c                      |  2 ++
>  tools/libxl/libxl.h                      |  7 +++++++
>  tools/libxl/libxl_types.idl              |  1 +

Hmm... I thought I acked this before, but that could be an old version
that I acked.

Acked-by: Wei Liu <wl@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel