Re: [Xen-devel] [PATCH v10 15/16] microcode: disable late loading if CPUs are affected by BDF90

[Jan Beulich <jbeulich@xxxxxxxx>]

On 17.09.2019 11:01, Chao Gao wrote:
> On Fri, Sep 13, 2019 at 11:22:59AM +0200, Jan Beulich wrote:
>> On 12.09.2019 09:22, Chao Gao wrote:
>>> --- a/xen/include/asm-x86/microcode.h
>>> +++ b/xen/include/asm-x86/microcode.h
>>> @@ -30,6 +30,7 @@ struct microcode_ops {
>>>      bool (*match_cpu)(const struct microcode_patch *patch);
>>>      enum microcode_match_result (*compare_patch)(
>>>          const struct microcode_patch *new, const struct microcode_patch 
>>> *old);
>>> +    bool (*is_blacklisted)(void);
>>
>> Why a hook rather than a boolean flag, which could be set by
>> microcode_update_one() (as invoked during AP bringup)?
> 
> How about set the boolean flag in Intel_errata_workarounds?

Wherever it ends up working best. My suggestion was just a wild
guess.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel