Re: [Xen-devel] [PATCH v10 5/6] iommu: tidy up iommu_use_hap_pt() and need_iommu_pt_sync() macros

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 13 September 2019 11:05
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Julien Grall <julien.grall@xxxxxxx>; 
> Andrew Cooper
> <Andrew.Cooper3@xxxxxxxxxx>; Roger Pau Monne <roger.pau@xxxxxxxxxx>; 
> Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxx>; Ian 
> Jackson
> <Ian.Jackson@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Konrad 
> Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>; Wei Liu <wl@xxxxxxx>
> Subject: Re: [PATCH v10 5/6] iommu: tidy up iommu_use_hap_pt() and 
> need_iommu_pt_sync() macros
> 
> On 13.09.2019 11:47, Paul Durrant wrote:
> > --- a/xen/include/xen/iommu.h
> > +++ b/xen/include/xen/iommu.h
> > @@ -56,8 +56,10 @@ extern bool_t iommu_enable, iommu_enabled;
> >  extern bool_t force_iommu, iommu_verbose, iommu_igfx;
> >  extern bool_t iommu_snoop, iommu_qinval, iommu_intremap, iommu_intpost;
> >
> > -#ifdef CONFIG_HVM
> > +#if defined(CONFIG_HVM)
> >  extern bool iommu_hap_pt_share;
> > +#elif defined(CONFIG_IOMMU_FORCE_PT_SHARE)
> > +#define iommu_hap_pt_share true
> >  #else
> >  #define iommu_hap_pt_share false
> >  #endif
> 
> The ordering is wrong here - Arm unconditionally defines HVM, and
> hence it now also setting IOMMU_FORCE_PT_SHARE won't be accounted
> for this way.

Ah yes, good point.

> I'd be happy to adjust this on commit, but I'm afraid
> I'm still unhappy about patch 3 (but I guess at this point I'll
> better propose a replacement than ask you for going through another
> round).
> 

That would be helpful.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel