Re: [Xen-devel] [PATCH] public/xen.h: update the comment explaining 'Wallclock time'

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 12 September 2019 17:03
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Julien Grall <julien.grall@xxxxxxx>; 
> Andrew Cooper
> <Andrew.Cooper3@xxxxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxx>; Ian 
> Jackson
> <Ian.Jackson@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Konrad 
> Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>; Wei Liu <wl@xxxxxxx>
> Subject: Re: [PATCH] public/xen.h: update the comment explaining 'Wallclock 
> time'
> 
> On 12.09.2019 16:05, Paul Durrant wrote:
> > Since commit 0629adfd80e "Actually set a HVM domain's time offset when it
> > sets the RTC", the comment in the public header has been misleading, since
> > it claims that wallclock time is only updated by control software.
> > Moreover, the comments stating that wc_sec and wc_nsec are seconds and
> > nanoseconds (respectively) in UTC since the Unix epoch are bogus. Their
> > values are adjusted by the domain's time_offset_seconds value, which is
> > updated by a guest write to the emulated RTC and hence the wallclock
> > timezone is under guest control.
> >
> > This patch attempts to bring the comment in line with reality whilst
> > keeping it reasonably short.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> (preferably with the typo fixed that Jürgen pointed out; easily
> done while committing)

OK. Thanks,

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel