Re: [Xen-devel] [PATCH] xen/arm: bootfd: Fix indentation in process_multiboot_node()

[Julien Grall <julien.grall@xxxxxxxxx>]

On Wed, 11 Sep 2019, 18:36 Volodymyr Babchuk, <Volodymyr_Babchuk@xxxxxxxx> wrote:

Julien Grall writes:

> One line in process_multiboot_node() is using hard tab rather than soft
> tab. So fix it!
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

So, hunting them one-by-one is the preferred way?

I usually do it while I touch code around. I found this one when debugging a boot regression today. You are welcome to fix the rest although...

I'm asking this
because there are more of them:

% find xen/arch/arm -type f -name "*.[ch]" -exec grep -lP "\t" {} \;
xen/arch/arm/traps.c
xen/arch/arm/acpi/boot.c
xen/arch/arm/arm32/lib/assembler.h
xen/arch/arm/arm64/livepatch.c
xen/arch/arm/arm64/lib/find_next_bit.c
xen/arch/arm/arm64/insn.c

The 4 above are a copy from Linux and therefore hard tab should stay.

Cheers,

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel