[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 1/2] sysctl/libxl: choose a sane default for HAP
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 10 Sep 2019 17:44:38 +0200
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=Pass smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Paul Durrant <paul.durrant@xxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 10 Sep 2019 15:44:51 +0000
- Ironport-sdr: JV6zW+hZysxlip1+jPLp/kVAqItov5OBCtyBm79uQbV302gkB3EVGRtXvm7WfbRCM3EZuT3RPJ B/MrEuOONIkFleglxhQf8XbSgQLxV8cJ6n4aftk5ukBjkU2vIYryar9xgaI6xvgRoIZfIRW5GQ be4TdlQictFOt3rG3BEEgmbDfDusU0i9RKlKl6FOyZtbJS7kkITluhjDFnz4KM9NK/DD1ZzzGQ JeLgtpMBGxN6FnTCoDo6MrhKALH+CL4wQRKordOyOpBSQ9Ot1qNl1fe9kRgFEq4MGgp2F6n/4I VK0=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Sep 10, 2019 at 04:40:39PM +0100, Andrew Cooper wrote:
> On 10/09/2019 16:25, Roger Pau Monne wrote:
> > diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml
> > index e544ef84da..a5e77c943a 100644
> > --- a/tools/ocaml/libs/xc/xenctrl.ml
> > +++ b/tools/ocaml/libs/xc/xenctrl.ml
> > @@ -107,6 +107,7 @@ type physinfo_cap_flag =
> > | CAP_HVM
> > | CAP_PV
> > | CAP_DirectIO
> > + | CAP_hap
>
> HAP is an initialism just like HVM, so definitely should be capitalised.
Funny thing, I had it all caps and then switched to this form
to match the sysctl define (XEN_SYSCTL_PHYSCAP_hap).
Would you like me to resend with all caps?
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
