Re: [Xen-devel] [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI build-time checks

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Christian Lindig writes ("Re: [PATCH 3/3] tools/ocaml: Introduce xenctrl ABI 
build-time checks"):
> I understand the desire to automate this but would have kept the
> original proposal for these reasons: changes are rare enough, it is
> obvious how to extend the scheme, the approach stayed well within
> the respective languages. Adding parsers and code generators to the
> build system will make it more difficult to improve it, which at
> least for the OCaml part is very desirable. However, I’m not going
> to object to the patch.

I would love to have this all done in a more "proper" way.

However, in the meantime I do think it is essential to have a check
which actually ties the ocaml code right back to the Xen headers (the
latter being the canonical ABI definition).  Indeed the v1 patch in
this very thread had a mismatch between the ocaml and the BUILD_BUG_ON
list, which I only discovered when my checker threw an unexpected
error.

If there are other language bindings which have similar issues we
should check them too.

Ultimately I would prefer it if the Xen ABI were provided in a way
that was useable for automatically generating bindings.

> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel