Re: [Xen-devel] [PATCH V3 1/8] iommu/arm: Add iommu_helpers.c file to keep common for IOMMUs stuff

[Oleksandr <olekstysh@xxxxxxxxx>]

On 09.09.19 14:45, Julien Grall wrote:
> Hi Oleksandr,
Hi, Julien


> On 8/20/19 7:09 PM, Oleksandr Tyshchenko wrote:
> > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> >
> > Introduce a separate file to keep various helpers which could be used
> > by more than one IOMMU driver in order not to duplicate code.
> >
> > The first candidates to be moved to the new file are SMMU driver's
> > "map_page/unmap_page" callbacks. There callbacks neither contain any
> s/There/These/ I think.
ok


> >   static __init const struct arm_smmu_device *find_smmu(const struct 
> > device *dev)
> > diff --git a/xen/include/asm-arm/iommu.h b/xen/include/asm-arm/iommu.h
> > index 904c9ae..20d865e 100644
> > --- a/xen/include/asm-arm/iommu.h
> > +++ b/xen/include/asm-arm/iommu.h
> > @@ -26,6 +26,13 @@ struct arch_iommu
> >   const struct iommu_ops *iommu_get_ops(void);
> >   void iommu_set_ops(const struct iommu_ops *ops);
> >   +/* mapping helpers */
> I would specify this only works when the PT is shared between the 
> IOMMU and CPU.
ok


> With the two requests addressed:
>
> Acked-by: Julien Grall <julien.grall@xxxxxxx>
Thank you


--
Regards,

Oleksandr Tyshchenko


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel