Re: [Xen-devel] [PATCH v6 1/5] xen: fix debugtrace clearing

[Jan Beulich <jbeulich@xxxxxxxx>]

On 09.09.2019 09:53, Jan Beulich wrote:
> On 09.09.2019 09:35, Juergen Gross wrote:
>> --- a/xen/drivers/char/console.c
>> +++ b/xen/drivers/char/console.c
>> @@ -1173,6 +1173,7 @@ static char        *debugtrace_buf; /* Debug-trace 
>> buffer */
>>  static unsigned int debugtrace_prd; /* Producer index     */
>>  static unsigned int debugtrace_kilobytes = 128, debugtrace_bytes;
>>  static unsigned int debugtrace_used;
>> +static bool debugtrace_buf_empty;
> 
> Wouldn't it be more logical for this to start out as "true"?
> And I'm debating with myself whether it might want to be
> __read_mostly.

Hmm, no, the latter rather not.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel