Re: [Xen-devel] [PATCH v2 00/12] livepatch: new features and fixes

[Julien Grall <julien.grall@xxxxxxx>]

Hi Konrad,

On 9/5/19 8:13 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Aug 27, 2019 at 08:46:12AM +0000, Pawel Wieczorkiewicz wrote:
> > This series introduces new features to the livepatch functionality as
> > briefly discussed during Xen Developer Summit 2019: [a] and [b].
> > It also provides a few fixes and some small improvements.
> >
> > Main changes in v2:
> > - added new features to livepatch documentation
> > - added livepatch tests
> > - enabled Arm support for [5]
> > - make .modinfo optional for [11]
> > - fixed typos
> I took your patches, redid them per what I had responded on these patches
> (and squashed your fix for xen_expectations) and stuck them in my branch:
>
> http://xenbits.xen.org/gitweb/?p=people/konradwilk/xen.git;a=shortlog;h=refs/heads/livepatch.aws.v3
>
> There are three extra patches that were needed for me to test on ARM32 - those
> are known issues and they don't block your patches. I will post them independent
> of your patches.
>
>  From my perspective, your patches are good to go.
>
> But I believe I need:
>   - the tools folks Ack on the libxc code changes,
>   - and also an Ack from the REST on sysctl.h,
>   - and Julian OK on the ARM32/ARM64 code changes which are tiny, but 
> nonethless are his.
I believe all the modifications are under in livepatch.c files. So your 
Ack should be sufficient here :).
Anyway, feel free to add mine on Arm specific modifications.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel