Re: [Xen-devel] [PATCH v8 1/6] x86/domain: remove the 'oos_off' flag

[Julien Grall <julien.grall@xxxxxxx>]

Hi Jan,

On 9/2/19 4:08 PM, Jan Beulich wrote:
> On 02.09.2019 16:50, Paul Durrant wrote:
> > The flag is not needed since the domain 'options' can now be tested
> > directly.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> In principle
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> but
>
> Julien, Stefano,
>
> I'd like to to ask for an explicit opinion of at least one of you
> regarding the behavior on Arm. During v7 review I did suggest that
> the flag being set should get rejected there.
The current code is actually rejecting any combination of flags but 
CDF_hvm_guest | CDF_hap. So the flag is effectively rejected for Arm.
However, it occurred to me that patch #2 will break domain creation on 
Arm as setting CDF_iommu will be prevented.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel