Re: [Xen-devel] [PATCH v5 3/4] xen: refactor debugtrace data

[Jan Beulich <jbeulich@xxxxxxxx>]

On 05.09.2019 13:39, Juergen Gross wrote:
> As a preparation for per-cpu buffers do a little refactoring of the
> debugtrace data: put the needed buffer admin data into the buffer as
> it will be needed for each buffer. In order not to limit buffer size
> switch the related fields from unsigned int to unsigned long, as on
> huge machines with RAM in the TB range it might be interesting to
> support buffers >4GB.

Just as a further remark in this regard:

>  void debugtrace_printk(const char *fmt, ...)
>  {
>      static char buf[DEBUG_TRACE_ENTRY_SIZE];
> -    static unsigned int count, last_count, last_prd;
> +    static unsigned int count, last_count;

How long do we think will it take until their wrapping will become
an issue with such huge buffers?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel