[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/3] VT-d: avoid PCI device lookup


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
  • Date: Thu, 5 Sep 2019 03:09:32 +0000
  • Accept-language: en-US
  • Delivery-date: Thu, 05 Sep 2019 03:09:43 +0000
  • Dlp-product: dlpe-windows
  • Dlp-reaction: no-action
  • Dlp-version: 11.0.400.15
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVYySOT2l5YjeoAUysB4srFLbm4qccZ0kw
  • Thread-topic: [PATCH 2/3] VT-d: avoid PCI device lookup

> From: Jan Beulich [mailto:jbeulich@xxxxxxxx]
> Sent: Wednesday, September 4, 2019 9:28 PM
> 
> The two uses of pci_get_pdev_by_domain() lack proper locking, but are
> also only used to get hold of a NUMA node ID. Calculate and store the
> node ID earlier on and remove the lookups (in lieu of fixing the
> locking).
> 
> While doing this it became apparent that iommu_alloc()'s use of
> alloc_pgtable_maddr() would occur before RHSAs would have been parsed:
> iommu_alloc() gets called from the DRHD parsing routine, which - on
> spec conforming platforms - happens strictly before RHSA parsing. Defer
> the allocation until after all ACPI table parsing has finished,
> established the node ID there first.
> 
> Suggested-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.