Re: [Xen-devel] [PATCH v1] Remove stale crashkernel= example from documentation

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.09.2019 16:13, Olaf Hering wrote:
> Am Wed, 4 Sep 2019 14:19:23 +0200
> schrieb Jan Beulich <jbeulich@xxxxxxxx>:
> 
>> On 04.09.2019 11:37, Olaf Hering wrote:
>>> Maybe just the lack of b49225dc9df336405292dc08862b4c7c9d887bd6 in vendor 
>>> binaries...  
>> But this change was only to deal with the bogus log message.
>> The handling was still correct (and the option was being
>> honored). I also can't see how this would be different now.
> 
> Is that true? My interpretation of the code path is that no
> colon and nothing after a size value will lead to EINVAL.

First of all - does "the code" here mean master/staging, or any
release branch? And then, yes, on release branches there will be
EINVAL, but as said before kexec_crash_area.size will get/remain
set nevertheless (as the error path doesn't zap any of the
earlier parsing outcome).

> With this change any unknown string will cause EINVAL.

Which is what should happen for unknown (i.e. unsupported) strings,
shouldn't it?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel