[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 3/5] xen: print lock profile info in panic()



On 03.09.2019 16:38, Juergen Gross wrote:
> On 03.09.19 16:22, Jan Beulich wrote:
>> On 29.08.2019 12:18, Juergen Gross wrote:
>>> V2:
>>> - rename CONFIG_LOCK_PROFILE to CONFIG_DEBUG_LOCK_PROFILE (Jan Beulich)
>>> - move .lockprofile.data section to init area in linker scripts
>>
>> How can this be correct, when you don't change lock_prof_init() at
>> all? The function builds a linked list from the entries in the
>> section, and then hands the head of this list to
>> _lock_profile_register_struct(). I guess I must be missing
>> something. Anyway, everything else here looks good to me.
> 
> The .lockprofile.data section contains only the pointers to the
> elements put into the linked list. And those pointers are no longer
> needed afterwards.

Oh, yes, I see now. Arguably worth making a separate change,
but since it's this way now
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.