Re: [Xen-devel] [PATCH v7 3/6] use is_iommu_enabled() where appropriate...

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 30 August 2019 14:58
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Suravee Suthikulpanit 
> <suravee.suthikulpanit@xxxxxxx>; JulienGrall
> <julien.grall@xxxxxxx>; Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Roger Pau 
> Monne
> <roger.pau@xxxxxxxxxx>; Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; 
> George Dunlap
> <George.Dunlap@xxxxxxxxxx>; Jun Nakajima <jun.nakajima@xxxxxxxxx>; Kevin Tian 
> <kevin.tian@xxxxxxxxx>;
> Stefano Stabellini <sstabellini@xxxxxxxxxx>; Daniel De Graaf 
> <dgdegra@xxxxxxxxxxxxx>; WeiLiu
> <wl@xxxxxxx>
> Subject: Re: [PATCH v7 3/6] use is_iommu_enabled() where appropriate...
> 
> On 30.08.2019 10:29, Paul Durrant wrote:
> > --- a/xen/include/asm-x86/iommu.h
> > +++ b/xen/include/asm-x86/iommu.h
> > @@ -61,8 +61,17 @@ extern struct iommu_ops iommu_ops;
> >
> >  #ifdef NDEBUG
> >  # include <asm/alternative.h>
> > -# define iommu_call(ops, fn, args...)  alternative_call(iommu_ops.fn, ## 
> > args)
> > -# define iommu_vcall(ops, fn, args...) alternative_vcall(iommu_ops.fn, ## 
> > args)
> > +# define iommu_call(ops, fn, args...)         \
> > +({                                            \
> > +    (void)ops;                                \
> > +    alternative_call(iommu_ops.fn, ## args);  \
> > +})
> > +
> > +# define iommu_vcall(ops, fn, args...)        \
> > +({                                            \
> > +    (void)ops;                                \
> > +    alternative_vcall(iommu_ops.fn, ## args); \
> > +})
> >  #endif
> 
> While unlikely to become an issue, "ops" should be parenthesized
> here. Also we commonly (but, granted, not consistently) put ({ on
> the #define line. Can both be done while committing.
> 

Ok, thanks.

  Paul

> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel