Re: [Xen-devel] [PATCH 10/20] create-diff-object: Do not include all .rodata sections

[Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>]

On 8/21/19 9:20 AM, Pawel Wieczorkiewicz wrote:
> Older versions of GCC did not split .rodata.str sections by function.
> Because of that, the entire section was always included.
> The livepatch-build-tools commit [1] fixed patch creation and kept
> including all .rodata.str sections, in order to maintain existing
> behavior for GCC 6.1+.
> This means all .rodata.str sections are always included by default,
> regardless of whether they are needed or not.
>
> During stacked hotpatch builds it leads to unnecessary accumulation of
> the .rodata.str sections as each and every consecutive hotpatch module
> contains all the .rodata.str sections of previous modules.
>
> To prevent this situation, mark the .rodata.str sections for inclusion
> only if they are referenced by any of the current hotpatch symbols (or
> a corresponding RELA section).
>
> Extend patchability verification to detect all non-standard, non-rela,
> non-debug and non-special sections that are not referenced by any of
> the symbols or RELA sections.
>
> Rename should_include_str_section() to is_rodata_str_section().
>
> [1] 2af6f1aa6233 Fix patch creation with GCC 6.1+
>
> Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
> Reviewed-by: Andra-Irina Paraschiv <andraprs@xxxxxxxxxx>
> Reviewed-by: Bjoern Doebel <doebel@xxxxxxxxx>
> Reviewed-by: Norbert Manthey <nmanthey@xxxxxxxxx>
> ---
Reviewed-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>

Thanks

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel