Re: [Xen-devel] [PATCH v1] docs: substitute XEN_CONFIG_DIR in xl.conf.5

[Wei Liu <wl@xxxxxxx>]

On Sun, Aug 18, 2019 at 06:27:26PM +0100, Andrew Cooper wrote:
> On 18/08/2019 18:20, Wei Liu wrote:
> > On Fri, Jun 21, 2019 at 11:30:05AM +0200, Olaf Hering wrote:
> >> xl(1) opens xl.conf in XEN_CONFIG_DIR.
> >> Substitute this variable also in the man page.
> >>
> >> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> >> ---
> >>  docs/man/xl.1.pod.in      | 2 +-
> >>  docs/man/xl.conf.5.pod.in | 2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in
> >> index 3d64eaa5b2..fb17153635 100644
> >> --- a/docs/man/xl.1.pod.in
> >> +++ b/docs/man/xl.1.pod.in
> >> @@ -50,7 +50,7 @@ setup the bridge.
> >>  
> >>  If you specify the amount of memory dom0 has, passing B<dom0_mem> to
> >>  Xen, it is highly recommended to disable B<autoballoon>. Edit
> >> -B</etc/xen/xl.conf> and set it to 0.
> >> +B<@XEN_CONFIG_DIR@/xl.conf> and set it to 0.
> >>  
> >>  =item run xl as B<root>
> >>  
> >> diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in
> >> index 2beb2119a8..b16036aaeb 100644
> >> --- a/docs/man/xl.conf.5.pod.in
> >> +++ b/docs/man/xl.conf.5.pod.in
> > Sorry for the late reply.
> >
> > This doesn't apply. There is no such file.
> 
> Hmm.  We have a xl.conf.5.pod which has no substitutions in, and I don't
> recall this changing.  Perhaps a logical dependency earlier in the SUSE
> patch queue?
> 
> I think this patch needs a {pod=>pod.in} rename as well, for it to apply
> to staging and work as intended.

I figured that as well.

Perhaps I missed the patch that did the renaming from Olaf.
Unfortunately I don't have the full xen-devel archive in my mailbox now.

Wei.

> 
> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel