[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()


  • To: Julien Grall <julien.grall@xxxxxxx>
  • From: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Date: Fri, 16 Aug 2019 16:32:35 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lX2IyShBtQM44HbPDeMqzujlcxddYxR5LhHfM6Q6D30=; b=iU4EIfmcBi90ko7crN3yC27CXF8bcYxwU0h0JR3XNz9mgX80AZlH8sd9sTYyDVccbnxHe6X1FC94RVE6cg8begDogZ7txJH+9jPi629SMuJLjCw7bvQkUc4s6IvYhb1fG/pSpObEUkMbdKP6uGZ1wmudcvIyGJ48BImyui4SE/Ve6G9SXg5CBUd3obP4xt4RolToLa6C0Wp+DjEWqZfikv+9DVvK7JIr6MyWH3elKXmLzR9h9YMXw4cSQ8aK2iUw/SKgSn9rhFlELB9XxDOkxgvmTs3VwWsG6b+/KHPjodXiexlu7JJVesz/KrCVFfVdHARpmZyz7dyfE4FYow9blw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gjYQFlUxVLQrMvI1FgaFAFvQLOtKNpcUR7hMqXNeK5iXhDpf+MnRrJePZZ9t26RbnJlcjBK7wynjkYmk1rUubbBBE8FXwYNif4ixDfJdgCJRS6OovwwctCHI5FHSVNZ/kI64doAfYrrxJS+2q/A1m4IDVx+tnmBJ9H02d6VDgdvyKJ0a42g1cyR35bu5Fi4AK7ySDXvBSjjPbFkSyhU7SojhrQ86Q9gdQ1GDwJN4VOB8xt4j961mBuTEjTdgskaK7w3b5avBsvTc+eXVyZ3RrmFqmAHnxav1pFO2f+5J2Em+gSCFyB/ED0EFE7E8FBU7G2BFTreEF6jtYcHLapiK3g==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Volodymyr_Babchuk@xxxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 16 Aug 2019 16:32:40 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVU4+AjqXYjsQ3PUyruzKYldcey6b9+UyA
  • Thread-topic: [PATCH] xen/arm: domain_build: Print the correct domain in initrd_load()

Julien Grall writes:

> initrd_load() can be called by other domain than dom0. To avoid
> confusion in the log, print the correct domain.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>

But why didn't you gathered all those patches into one patch series?
> ---
>  xen/arch/arm/domain_build.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index 126374f603..33171081ea 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1818,8 +1818,8 @@ static void __init initrd_load(struct kernel_info 
> *kinfo)
>      paddr = mod->start;
>      len = mod->size;
>  
> -    printk("Loading dom0 initrd from %"PRIpaddr" to 
> 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> -           paddr, load_addr, load_addr + len);
> +    printk("Loading %pd initrd from %"PRIpaddr" to 
> 0x%"PRIpaddr"-0x%"PRIpaddr"\n",
> +           kinfo->d, paddr, load_addr, load_addr + len);
>  
>      /* Fix up linux,initrd-start and linux,initrd-end in /chosen */
>      node = fdt_path_offset(kinfo->fdt, "/chosen");


-- 
Volodymyr Babchuk at EPAM
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.