Re: [Xen-devel] [PATCH lp-metadata 3/3] livepatch: Add metadata runtime retrieval mechanism

[Wei Liu <wl@xxxxxxx>]

On Fri, Aug 16, 2019 at 12:54:12PM +0000, Wieczorkiewicz, Pawel wrote:
> 
> > On 16. Aug 2019, at 14:44, Wei Liu <wl@xxxxxxx> wrote:
> > 
> > On Thu, Aug 15, 2019 at 11:27:50AM +0000, Pawel Wieczorkiewicz wrote:
> >> Extend the livepatch list operation to fetch also payloads' metadata.
> >> This is achieved by extending the sysctl list interface with 2 extra
> >> guest handles:
> >> * metadata     - an array of arbitrary size strings
> >> * metadata_len - an array of metadata strings' lengths (uin32_t each)
> 
> …snip...
> 
> >> Signed-off-by: Pawel Wieczorkiewicz <wipawel@xxxxxxxxx>
> >> Reviewed-by: Andra-Irina Paraschiv <andraprs@xxxxxxxxxx>
> >> Reviewed-by: Martin Pohlack <mpohlack@xxxxxxxxx>
> >> Reviewed-by: Norbert Manthey <nmanthey@xxxxxxxxx>
> >> ---
> >> tools/libxc/include/xenctrl.h | 22 +++++++++++----
> >> tools/libxc/xc_misc.c         | 66 
> >> +++++++++++++++++++++++++++++++++++--------
> >> tools/misc/xen-livepatch.c    | 43 ++++++++++++++++++++++------
> >> xen/common/livepatch.c        | 22 +++++++++++----
> >> xen/include/public/sysctl.h   | 19 +++++++++----
> > 
> > Mostly look good. One comment below...
> > 
> >> diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h
> >> index b86804b7a6..e4c8f4fe63 100644
> >> --- a/xen/include/public/sysctl.h
> >> +++ b/xen/include/public/sysctl.h
> > 
> > If it hasn't been done for this release already, changing sysctl interface 
> > requires
> > bumping the version number in this header.
> > 
> 
> ACK. Will do (also for earlier patches…).
> 

We only need to do it once per release. :-)

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel