Re: [Xen-devel] [PATCH] get_maintainers.pl: Enable running the script on unikraft repos

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 16/08/2019, 13:09, "Paul Durrant" <Paul.Durrant@xxxxxxxxxx> wrote:

    > -----Original Message-----
    > From: Lars Kurth <lars.kurth@xxxxxxxxxx>
    > Sent: 16 August 2019 13:05
    > To: Anthony Perard <anthony.perard@xxxxxxxxxx>; Julien Grall 
<julien.grall@xxxxxxx>
    > Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Felipe Huici 
<felipe.huici@xxxxxxxxx>; Stefano Stabellini
    > <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Konrad Rzeszutek Wilk 
<konrad.wilk@xxxxxxxxxx>; George
    > Dunlap <George.Dunlap@xxxxxxxxxx>; Andrew Cooper 
<Andrew.Cooper3@xxxxxxxxxx>; Ian Jackson
    > <Ian.Jackson@xxxxxxxxxx>; Tim (Xen.org) <tim@xxxxxxx>; Florian Schmidt 
<florian.schmidt@xxxxxxxxx>;
    > Jan Beulich <jbeulich@xxxxxxxx>; Simon Kuenzer <simon.kuenzer@xxxxxxxxx>; 
Paul Durrant
    > <Paul.Durrant@xxxxxxxxxx>
    > Subject: Re: [Xen-devel] [PATCH] get_maintainers.pl: Enable running the 
script on unikraft repos
    > 
    > Added Paul Durrant
    > 
    > On 16/08/2019, 12:17, "Anthony PERARD" <anthony.perard@xxxxxxxxxx> wrote:
    > 
    >     On Fri, Aug 16, 2019 at 11:55:16AM +0100, Julien Grall wrote:
    >     > Hi Lars,
    >     >
    >     > On 16/08/2019 11:42, Lars Kurth wrote:
    >     > > Unikraft repos follow the same syntax as xen.git with the
    >     > > following exceptions:
    >     > > * MAINTAINERS files are called MAINTAINERS.md
    >     > > * M: ... etc blocks are preceded by whitespaces for rendering as
    >     > >    markup files
    >     >
    >     > There is an other difference. The "fallback" category is "UNIKRAFT 
GENERAL"
    >     > and not "THE REST".
    >     >
    >     > >
    >     > > This change will
    >     > > - load MAINTAINERS.md if MAINTAINERS is not present
    >     > > - deal with indented M: ... blocks
    >     >
    >     > One process question. Does it mean Unikraft folks will have to 
checkout Xen
    >     > in order to use {add, get}_maintainers.pl? If so, would it make 
sense to
    >     > have add_maintainers.pl and script_maintainers.pl in a separate 
repo that
    >     > can be added as submodule?
    > 
    >     Shouldn't instead the Unikraft repo have it's one get_maintainers
    >     script? xen.git's script doesn't needs to have support for every 
single
    >     repo available on earth and Unikraft is a different project anyway.
    > 
    >     Usually, projects with a MAINTAINERS file have there own 
get_maintainers
    >     script.
    > 
    > Well: Unikraft is part of the Xen Project.
    > 
    > When I started to clean up the contribution docs it became apparent that
    > there is a lot of inconsistency. Ideally our contribution guide [0] would 
apply
    > to pretty much *all* sub projects which use a mailing list based workflows
    > 
    > Consistency makes life for developers and also newcomers much easier. And 
the
    > number of new devs who seem to trip over inconsistencies between projects 
are
    > quite large (we had 3  cases in 3 weeks which I noticed).
    > 
    > If we start improving our CI infrastructure (which we are), it would be 
nice if other
    > sub projects had the possibility to easily hook into it or replicate it. 
But that does require
    > some consistency.
    > 
    > That's why I submitted [1] and [2]
    > 
    > Sub-projects with mail based workflows
    > 1: Hypervisor
    > 2: Hypervisor related repos (livepatch-build-tools, mini-os, xtf, ...)
    > 3: Windows PV Drivers - which will require changes to their MAINTAINERS 
file
    > 4: Unikraft
    > 
    > Supporting 1 - 3 should be straightforward because you would almost always
    > have xen.git checked out. 4 is more different.
    
    I'd say that folks building 3 are unlikely to have xen.git checked out.
    
Good to know

If there was tooling available that simplifies your workflow, would 
members of the Windows PV Drivers sub-project be willing to use them?

It maybe that for Windows PV Drivers the workflow is not at all command
line based and people tend to use an IDE instead.

Lars
    

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel