[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [Qemu-devel] [PATCH v7 00/42] Invert Endian bit in SPARCv9 MMU TTE
- To: tony.nguyen@xxxxxx, qemu-devel@xxxxxxxxxx
- From: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
- Date: Fri, 16 Aug 2019 11:58:05 +0200
- Cc: frederic.konrad@xxxxxxxxxxx, berto@xxxxxxxxxx, qemu-block@xxxxxxxxxx, arikalo@xxxxxxxxxxxx, pasic@xxxxxxxxxxxxx, hpoussin@xxxxxxxxxxx, anthony.perard@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, balrogg@xxxxxxxxx, jasowang@xxxxxxxxxx, jiri@xxxxxxxxxxx, ehabkost@xxxxxxxxxx, b.galvani@xxxxxxxxx, eric.auger@xxxxxxxxxx, alex.williamson@xxxxxxxxxx, stefanha@xxxxxxxxxx, jsnow@xxxxxxxxxx, rth@xxxxxxxxxxx, kwolf@xxxxxxxxxx, andrew@xxxxxxxx, claudio.fontana@xxxxxxxx, crwulff@xxxxxxxxx, laurent@xxxxxxxxx, sundeep.lkml@xxxxxxxxx, michael@xxxxxxxx, qemu-ppc@xxxxxxxxxx, kbastian@xxxxxxxxxxxxxxxxxxxxx, imammedo@xxxxxxxxxx, fam@xxxxxxxxxx, peter.maydell@xxxxxxxxxx, david@xxxxxxxxxx, palmer@xxxxxxxxxx, balaton@xxxxxxxxxx, keith.busch@xxxxxxxxx, jcmvbkbc@xxxxxxxxx, hare@xxxxxxxx, sstabellini@xxxxxxxxxx, andrew.smirnov@xxxxxxxxx, deller@xxxxxx, magnus.damm@xxxxxxxxx, marcel.apfelbaum@xxxxxxxxx, atar4qemu@xxxxxxxxx, minyard@xxxxxxx, sw@xxxxxxxxxxx, yuval.shaia@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx, qemu-arm@xxxxxxxxxx, jan.kiszka@xxxxxx, clg@xxxxxxxx, shorne@xxxxxxxxx, qemu-riscv@xxxxxxxxxx, i.mitsyanko@xxxxxxxxx, cohuck@xxxxxxxxxx, amarkovic@xxxxxxxxxxxx, peter.chubb@xxxxxxxxxxxx, aurelien@xxxxxxxxxxx, pburton@xxxxxxxxxxxx, sagark@xxxxxxxxxxxxxxxxx, green@xxxxxxxxxxxxxx, kraxel@xxxxxxxxxx, edgar.iglesias@xxxxxxxxx, gxt@xxxxxxxxxxxxxxx, robh@xxxxxxxxxx, borntraeger@xxxxxxxxxx, joel@xxxxxxxxx, antonynpavlov@xxxxxxxxx, chouteau@xxxxxxxxxxx, lersek@xxxxxxxxxx, Andrew.Baumann@xxxxxxxxxxxxx, mreitz@xxxxxxxxxx, walling@xxxxxxxxxxxxx, dmitry.fleytman@xxxxxxxxx, mst@xxxxxxxxxx, mark.cave-ayland@xxxxxxxxxxxx, jslaby@xxxxxxx, marex@xxxxxxx, proljc@xxxxxxxxx, marcandre.lureau@xxxxxxxxxx, alistair@xxxxxxxxxxxxx, paul.durrant@xxxxxxxxxx, david@xxxxxxxxxxxxxxxxxxxxx, xiaoguangrong.eric@xxxxxxxxx, huth@xxxxxxxxxxxxx, jcd@xxxxxxxxxxxxxxx, pbonzini@xxxxxxxxxx, stefanb@xxxxxxxxxxxxx
- Delivery-date: Fri, 16 Aug 2019 09:58:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE
Hi Tony,
On 8/16/19 8:28 AM, tony.nguyen@xxxxxx wrote:
> This patchset implements the IE (Invert Endian) bit in SPARCv9 MMU TTE.
>
> v7:
[...]
> - Re-declared many native endian devices as little or big endian. This is why
> v7 has +16 patches.
Why are you doing that? What is the rational?
Anyhow if this not required by your series, you should split it out of
it, and send it on your principal changes are merged.
I'm worried because this these new patches involve many subsystems (thus
maintainers) and reviewing them will now take a fair amount of time.
> For each device declared with DEVICE_NATIVE_ENDIAN, find the set of
> targets from the set of target/hw/*/device.o.
>
> If the set of targets are all little or all big endian, re-declare
> the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN
> respectively.
If only little endian targets use a device, that doesn't mean the device
is designed in little endian...
Then if a big endian target plan to use this device, it will require
more work and you might have introduced regressions...
I'm not sure this is a safe move.
> This *naive* deduction may result in genuinely native endian devices
> being incorrectly declared as little or big endian, but should not
> introduce regressions for current targets.
Regards,
Phil.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
