[Xen-devel] [Qemu-devel] [PATCH v7 29/42] hw/ssi: Declare device little or big endian

[<tony.nguyen@xxxxxx>]

For each device declared with DEVICE_NATIVE_ENDIAN, find the set of

targets from the set of target/hw/*/device.o.

If the set of targets are all little or all big endian, re-declare

the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN

respectively.

This *naive* deduction may result in genuinely native endian devices

being incorrectly declared as little or big endian, but should not

introduce regressions for current targets.

These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it

has a new target with an opposite endian or 2) someone informed knows

better =)

Signed-off-by: Tony Nguyen <tony.nguyen@xxxxxx>

---

 hw/ssi/mss-spi.c       | 2 +-

 hw/ssi/pl022.c         | 2 +-

 hw/ssi/stm32f2xx_spi.c | 2 +-

 hw/ssi/xilinx_spips.c  | 2 +-

 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/ssi/mss-spi.c b/hw/ssi/mss-spi.c

index 4c9da5d..71fd138 100644

--- a/hw/ssi/mss-spi.c

+++ b/hw/ssi/mss-spi.c

@@ -359,7 +359,7 @@ static void spi_write(void *opaque, hwaddr addr,

 static const MemoryRegionOps spi_ops = {

     .read = spi_read,

     .write = spi_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

     .valid = {

         .min_access_size = 1,

         .max_access_size = 4

diff --git a/hw/ssi/pl022.c b/hw/ssi/pl022.c

index fec73ca..10d1995 100644

--- a/hw/ssi/pl022.c

+++ b/hw/ssi/pl022.c

@@ -226,7 +226,7 @@ static void pl022_reset(DeviceState *dev)

 static const MemoryRegionOps pl022_ops = {

     .read = pl022_read,

     .write = pl022_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static int pl022_post_load(void *opaque, int version_id)

diff --git a/hw/ssi/stm32f2xx_spi.c b/hw/ssi/stm32f2xx_spi.c

index 4249101..e1e5ab5 100644

--- a/hw/ssi/stm32f2xx_spi.c

+++ b/hw/ssi/stm32f2xx_spi.c

@@ -166,7 +166,7 @@ static void stm32f2xx_spi_write(void *opaque, hwaddr addr,

 static const MemoryRegionOps stm32f2xx_spi_ops = {

     .read = stm32f2xx_spi_read,

     .write = stm32f2xx_spi_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static const VMStateDescription vmstate_stm32f2xx_spi = {

diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c

index b29e0a4..8cadc4e 100644

--- a/hw/ssi/xilinx_spips.c

+++ b/hw/ssi/xilinx_spips.c

@@ -1238,7 +1238,7 @@ static MemTxResult lqspi_write(void *opaque, hwaddr offset, uint64_t value,

 static const MemoryRegionOps lqspi_ops = {

     .read_with_attrs = lqspi_read,

     .write_with_attrs = lqspi_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

     .impl = {

         .min_access_size = 4,

         .max_access_size = 4,

-- 

1.8.3.1

​

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel