[Xen-devel] [Qemu-devel] [PATCH v7 21/42] hw/i2c: Declare device little or big endian

[<tony.nguyen@xxxxxx>]

For each device declared with DEVICE_NATIVE_ENDIAN, find the set of

targets from the set of target/hw/*/device.o.

If the set of targets are all little or all big endian, re-declare

the device endianness as DEVICE_LITTLE_ENDIAN or DEVICE_BIG_ENDIAN

respectively.

This *naive* deduction may result in genuinely native endian devices

being incorrectly declared as little or big endian, but should not

introduce regressions for current targets.

These devices should be re-declared as DEVICE_NATIVE_ENDIAN if 1) it

has a new target with an opposite endian or 2) someone informed knows

better =)

Signed-off-by: Tony Nguyen <tony.nguyen@xxxxxx>

---

 hw/i2c/imx_i2c.c       | 2 +-

 hw/i2c/mpc_i2c.c       | 2 +-

 hw/i2c/versatile_i2c.c | 2 +-

 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c

index ce7a94c..de1107b 100644

--- a/hw/i2c/imx_i2c.c

+++ b/hw/i2c/imx_i2c.c

@@ -276,7 +276,7 @@ static const MemoryRegionOps imx_i2c_ops = {

     .write = imx_i2c_write,

     .valid.min_access_size = 1,

     .valid.max_access_size = 2,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static const VMStateDescription imx_i2c_vmstate = {

diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c

index e9a1127..181228d 100644

--- a/hw/i2c/mpc_i2c.c

+++ b/hw/i2c/mpc_i2c.c

@@ -304,7 +304,7 @@ static const MemoryRegionOps i2c_ops = {

     .read =  mpc_i2c_read,

     .write =  mpc_i2c_write,

     .valid.max_access_size = 1,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_BIG_ENDIAN,

 };

 

 static const VMStateDescription mpc_i2c_vmstate = {

diff --git a/hw/i2c/versatile_i2c.c b/hw/i2c/versatile_i2c.c

index 1ac2a6f..c92d3b1 100644

--- a/hw/i2c/versatile_i2c.c

+++ b/hw/i2c/versatile_i2c.c

@@ -77,7 +77,7 @@ static void versatile_i2c_write(void *opaque, hwaddr offset,

 static const MemoryRegionOps versatile_i2c_ops = {

     .read = versatile_i2c_read,

     .write = versatile_i2c_write,

-    .endianness = DEVICE_NATIVE_ENDIAN,

+    .endianness = DEVICE_LITTLE_ENDIAN,

 };

 

 static void versatile_i2c_init(Object *obj)

-- 

1.8.3.1

​

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel